From 2540616f43c389d22c404ca1efda46f29b936f1a Mon Sep 17 00:00:00 2001 From: Minseo Lee Date: Fri, 7 Jun 2024 13:41:03 +0900 Subject: [PATCH 1/2] Fix horizontal padding of tab within profile header (#3924) Co-authored-by: Hailey --- src/view/com/pager/PagerWithHeader.web.tsx | 15 +++++++-------- src/view/com/pager/TabBar.tsx | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/view/com/pager/PagerWithHeader.web.tsx b/src/view/com/pager/PagerWithHeader.web.tsx index 9c63c149fe..fe260feafd 100644 --- a/src/view/com/pager/PagerWithHeader.web.tsx +++ b/src/view/com/pager/PagerWithHeader.web.tsx @@ -1,11 +1,12 @@ import * as React from 'react' import {FlatList, ScrollView, StyleSheet, View} from 'react-native' import {useAnimatedRef} from 'react-native-reanimated' -import {Pager, PagerRef, RenderTabBarFnProps} from 'view/com/pager/Pager' -import {TabBar} from './TabBar' + import {usePalette} from '#/lib/hooks/usePalette' import {useWebMediaQueries} from '#/lib/hooks/useWebMediaQueries' +import {Pager, PagerRef, RenderTabBarFnProps} from 'view/com/pager/Pager' import {ListMethods} from '../util/List' +import {TabBar} from './TabBar' export interface PagerWithHeaderChildParams { headerHeight: number @@ -184,8 +185,7 @@ function PagerItem({ const styles = StyleSheet.create({ headerContainerDesktop: { - marginLeft: 'auto', - marginRight: 'auto', + marginHorizontal: 'auto', width: 600, borderLeftWidth: 1, borderRightWidth: 1, @@ -198,15 +198,14 @@ const styles = StyleSheet.create({ zIndex: 1, }, tabBarContainerDesktop: { - marginLeft: 'auto', - marginRight: 'auto', + marginHorizontal: 'auto', + paddingHorizontal: 2, width: 600, borderLeftWidth: 1, borderRightWidth: 1, }, tabBarContainerMobile: { - paddingLeft: 14, - paddingRight: 14, + paddingHorizontal: 0, }, loadingHeader: { borderColor: 'transparent', diff --git a/src/view/com/pager/TabBar.tsx b/src/view/com/pager/TabBar.tsx index e81d7d44da..e940e8d1a9 100644 --- a/src/view/com/pager/TabBar.tsx +++ b/src/view/com/pager/TabBar.tsx @@ -191,7 +191,7 @@ const mobileStyles = StyleSheet.create({ }, contentContainer: { backgroundColor: 'transparent', - paddingHorizontal: 8, + paddingHorizontal: 6, }, item: { paddingTop: 10, From fefae27396d914e7b6e92cd52f300c4e919aaf65 Mon Sep 17 00:00:00 2001 From: Hailey Date: Thu, 6 Jun 2024 22:29:34 -0700 Subject: [PATCH 2/2] scope enable/disable of keyboard controller in composer to only android (#4412) --- src/view/com/composer/Composer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/view/com/composer/Composer.tsx b/src/view/com/composer/Composer.tsx index 5807488393..3c2b8db2d2 100644 --- a/src/view/com/composer/Composer.tsx +++ b/src/view/com/composer/Composer.tsx @@ -134,8 +134,8 @@ export const ComposePost = observer(function ComposePost({ // See https://github.com/bluesky-social/social-app/pull/4399 const {setEnabled} = useKeyboardContext() React.useEffect(() => { + if (!isAndroid) return setEnabled(false) - return () => { setEnabled(true) }