From 92d15da0a51a917a4bed9dc30d7f2a10f51a0455 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Tue, 18 Aug 2026 16:46:39 +0300 Subject: [PATCH] remove custom japan logo --- ASSETS.md | 12 +++++------- assets/icons/custom/custom_logo_japan.svg | 1 - src/analytics/features/types.ts | 1 - src/view/com/auth/SplashScreen.web.tsx | 3 +-- src/view/com/home/HomeHeaderLayout.web.tsx | 10 +--------- src/view/com/home/HomeHeaderLayoutMobile.tsx | 4 +--- src/view/icons/Logo.tsx | 13 +++++-------- src/view/icons/useLogoVariant.ts | 11 +---------- 8 files changed, 14 insertions(+), 41 deletions(-) delete mode 100644 assets/icons/custom/custom_logo_japan.svg diff --git a/ASSETS.md b/ASSETS.md index 5b61b8f1d9..ebc93679cf 100644 --- a/ASSETS.md +++ b/ASSETS.md @@ -17,10 +17,9 @@ For the assets Bluesky itself owns, we are not treating anyone's past use as bad | Where | Rights holder | Our MIT license covers it? | If you fork | |---|---|---|---| | [`assets/illustrations/`](#1-commissioned-artwork--licensed-to-bluesky-only) | Owen D. Pomery, via Brilliant Artists Ltd | No | Replace | -| [`assets/icons/ui/`](#2-licensed-icon-system--not-ours-to-pass-on), Central glyphs in `assets/icons/custom/`, and Central icon glyphs in `bskyembed/assets/` except the Starter Pack mark | Iconists (David & Storm GbR) | No | Source your own | +| [`assets/icons/ui/`](#2-licensed-icon-system--not-ours-to-pass-on) and Central icon glyphs in `bskyembed/assets/` except the Starter Pack mark | Iconists (David & Storm GbR) | No | Source your own | | [Bluesky marks](#3-bluesky-trademarks-and-brand-assets) — app icons, logos, favicons | Bluesky Social PBC | No | Replace | | [`assets/kawaii.png`, `assets/kawaii_smol.png`](#4-community-and-contest-artwork--credited-but-not-ours-to-license) | [@sawaratsuki.bsky.social](https://bsky.app/profile/sawaratsuki.bsky.social) | No | Replace or remove | -| [`assets/icons/custom/custom_logo_japan.svg`](#4-community-and-contest-artwork--credited-but-not-ours-to-license) | A Bluesky Japan logo contest entrant | No | Replace or remove | | [`assets/icons/brands/AppleLogo.svg`](#5-third-party-trademarks) | Apple Inc. | No | Rests on your own basis | | [`assets/icons/brands/AndroidLogo.svg`](#5-third-party-trademarks) | Google LLC | No | Rests on your own basis | | [`assets/icons/community/`](#5-third-party-trademarks) | Leaflet, Offprint, pckt, Standard.site, Germ Network | No | Rests on your own basis | @@ -50,13 +49,13 @@ See [`assets/illustrations/README.md`](./assets/illustrations/README.md). ## 2. Licensed icon system — not ours to pass on -**`assets/icons/ui/`, Central glyphs in `assets/icons/custom/`, and the Central icon glyphs in `bskyembed/assets/`, except `bskyembed/assets/starterPack.svg`** +**`assets/icons/ui/` and the Central icon glyphs in `bskyembed/assets/`, except `bskyembed/assets/starterPack.svg`** -**Rights holder: Iconists (David & Storm GbR).** The user-interface glyphs in `assets/icons/ui/` (and any deliberate raw Central multi-path exceptions in `assets/icons/custom/`), plus copies of several in `bskyembed/assets/`, come from their [Central icon system](https://iconists.co/central). Bluesky Social PBC licenses them for use in our own products. **That license is for our own use. It does not include the right to pass any rights to the icons on to you.** +**Rights holder: Iconists (David & Storm GbR).** The user-interface glyphs in `assets/icons/ui/`, plus copies of several in `bskyembed/assets/`, come from their [Central icon system](https://iconists.co/central). Bluesky Social PBC licenses them for use in our own products. **That license is for our own use. It does not include the right to pass any rights to the icons on to you.** The fact that we have our own license does not mean that you cannot use these icons. It means that any right you have to use them has to come from Iconists, not us. Licenses are available from [iconists.co](https://iconists.co), and there are openly licensed alternatives if you prefer that. -The policy directories keep exceptions out of this license scope. `assets/icons/brands/` and `assets/icons/community/` are described below, non-Central artwork in `assets/icons/custom/` is covered separately, and `assets/icons/flags/` is covered by [Section 6](#6-third-party-assets-you-may-redistribute). +The policy directories keep exceptions out of this license scope. `assets/icons/brands/` and `assets/icons/community/` are described below, and `assets/icons/flags/` is covered by [Section 6](#6-third-party-assets-you-may-redistribute). See [`assets/icons/README.md`](./assets/icons/README.md). @@ -106,7 +105,6 @@ These are third-party artworks that appear in the app with attribution. We hold - `assets/kawaii.png` and `assets/kawaii_smol.png` — **rights holder: [@sawaratsuki.bsky.social](https://bsky.app/profile/sawaratsuki.bsky.social)**. Shown as an opt-in variant and credited in `src/view/shell/Drawer.tsx` and `src/view/shell/desktop/RightNav.tsx`. -- `assets/icons/custom/custom_logo_japan.svg` — **rights holder: the entrant who won the Bluesky Japan logo contest.** Replace or remove these if you fork. If you want to use them, contact the artist. @@ -162,7 +160,7 @@ If you are forking, replace these or ship without them. See [`assets/images/READ You have our blessing to fork this application. These steps map one-to-one to the sections above. 1. **Replace `assets/illustrations/`** — commissioned artwork, licensed to Bluesky only. [Section 1](#1-commissioned-artwork--licensed-to-bluesky-only) -2. **Source your own UI icons** — the Central glyphs in `assets/icons/ui/` and any raw Central exceptions in `assets/icons/custom/` are licensed to us for our own use. [Section 2](#2-licensed-icon-system--not-ours-to-pass-on) +2. **Source your own UI icons** — the Central glyphs in `assets/icons/ui/` are licensed to us for our own use. [Section 2](#2-licensed-icon-system--not-ours-to-pass-on) 3. **Replace the Bluesky marks** — app icons, favicons, logo files, and the inline logo paths in `src/view/icons/`. [Section 3](#3-bluesky-trademarks-and-brand-assets) 4. **Replace or remove the community and contest artwork.** [Section 4](#4-community-and-contest-artwork--credited-but-not-ours-to-license) 5. **Check your own position on the third-party marks.** [Section 5](#5-third-party-trademarks) diff --git a/assets/icons/custom/custom_logo_japan.svg b/assets/icons/custom/custom_logo_japan.svg deleted file mode 100644 index a55861faee..0000000000 --- a/assets/icons/custom/custom_logo_japan.svg +++ /dev/null @@ -1 +0,0 @@ - diff --git a/src/analytics/features/types.ts b/src/analytics/features/types.ts index 4d3cf5e197..5e3a8484af 100644 --- a/src/analytics/features/types.ts +++ b/src/analytics/features/types.ts @@ -17,7 +17,6 @@ export enum Features { ComposerLanguageDetectionEnable = 'composer:language_detection:enable', PostGalleryEmbedEnable = 'post_gallery_embed:enable', PostThreadKnownLikersEnable = 'post_thread:known_likers:enable', - CustomLogoJapanEnable = 'custom_logo:japan:enable', SearchStarterPacksV2Enable = 'search_starter_packs_v2:enable', FollowSortEnable = 'follow_sort:enable', OnboardingInterestsRequiredEnable = 'onboarding:interests:required:enable', diff --git a/src/view/com/auth/SplashScreen.web.tsx b/src/view/com/auth/SplashScreen.web.tsx index 6a6547e5e7..52c48e6744 100644 --- a/src/view/com/auth/SplashScreen.web.tsx +++ b/src/view/com/auth/SplashScreen.web.tsx @@ -48,7 +48,6 @@ export const SplashScreen = ({ const logoVariant = useLogoVariant() const kawaii = logoVariant === 'kawaii' - const japanLogo = logoVariant === 'japan' return ( <> @@ -82,7 +81,7 @@ export const SplashScreen = ({ ]}> - + {!kawaii && ( diff --git a/src/view/com/home/HomeHeaderLayout.web.tsx b/src/view/com/home/HomeHeaderLayout.web.tsx index ffd09523f5..835bcdcc51 100644 --- a/src/view/com/home/HomeHeaderLayout.web.tsx +++ b/src/view/com/home/HomeHeaderLayout.web.tsx @@ -51,15 +51,7 @@ function HomeHeaderLayoutDesktopAndTablet({ style={[a.flex_row, a.align_center, gutters, a.pt_md, t.atoms.bg]}> - + () - const logoVariant = useLogoVariant() return ( - + diff --git a/src/view/icons/Logo.tsx b/src/view/icons/Logo.tsx index 5b8d9dd318..44f8bda10d 100644 --- a/src/view/icons/Logo.tsx +++ b/src/view/icons/Logo.tsx @@ -34,21 +34,18 @@ export const Logo = forwardRef(function LogoImpl(props: Props, ref) { const logoVariant = useLogoVariant(allowVariants) - if (logoVariant !== 'default') { - const isJapanLogo = logoVariant === 'japan' + if (logoVariant === 'kawaii') { return ( 100 - ? require('../../../assets/kawaii.png') - : require('../../../assets/kawaii_smol.png') + size > 100 + ? require('../../../assets/kawaii.png') + : require('../../../assets/kawaii_smol.png') } accessibilityLabel="Bluesky" accessibilityHint="" accessibilityIgnoresInvertColors - style={[{height: size, aspectRatio: isJapanLogo ? 2 : 1.4}]} + style={[{height: size, aspectRatio: 1.4}]} /> ) } diff --git a/src/view/icons/useLogoVariant.ts b/src/view/icons/useLogoVariant.ts index c05d047ac2..360f4a37de 100644 --- a/src/view/icons/useLogoVariant.ts +++ b/src/view/icons/useLogoVariant.ts @@ -1,20 +1,11 @@ import {useKawaiiMode} from '#/state/preferences/kawaii' -import {useAnalytics} from '#/analytics' -import {useGeolocation} from '#/geolocation' -export type LogoVariant = 'default' | 'japan' | 'kawaii' +export type LogoVariant = 'default' | 'kawaii' export function useLogoVariant(allowVariants = true): LogoVariant { - const ax = useAnalytics() - const geolocation = useGeolocation() const kawaii = useKawaiiMode() - const japanLogoEnabled = - allowVariants && - geolocation.countryCode === 'JP' && - ax.features.enabled(ax.features.CustomLogoJapanEnable) if (!allowVariants) return 'default' - if (japanLogoEnabled) return 'japan' if (kawaii) return 'kawaii' return 'default' }