acetheking987/bsky-social-app
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Don't log downsample warning when unnecessary (#4291)

Browse Source 
* fix log

use process.env

ensure the log happens regardless of `isDownsampledSession`

fix log

* oops, revert test
This commit is contained in:
Hailey
2024-05-30 17:52:56 -07:00
committed by GitHub
parent d6275e98c2
commit 8e2c21a882
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/statsig/statsig.tsx
+10 -7
View File
@@ -102,16 +102,19 @@ export function logEvent<E extends keyof LogEvents>(
rawMetadata: LogEvents[E] & FlatJSONRecord, rawMetadata: LogEvents[E] & FlatJSONRecord,
) { ) {
try { try {
if (
process.env.NODE_ENV === 'development' &&
eventName.endsWith(':sampled') &&
!DOWNSAMPLED_EVENTS.has(eventName)
) {
logger.error(
'Did you forget to add ' + eventName + ' to DOWNSAMPLED_EVENTS?',
)
}
if (isDownsampledSession && DOWNSAMPLED_EVENTS.has(eventName)) { if (isDownsampledSession && DOWNSAMPLED_EVENTS.has(eventName)) {
return return
} }
if (process.env.NODE_ENV === 'development') {
if (eventName.endsWith(':sampled')) {
logger.error(
'Did you forget to add ' + eventName + ' to DOWNSAMPLED_EVENTS?',
)
}
}
const fullMetadata = { const fullMetadata = {
...rawMetadata, ...rawMetadata,
} as Record<string, string> // Statsig typings are unnecessarily strict here. } as Record<string, string> // Statsig typings are unnecessarily strict here.