Fix crash with translate link on web (#9972)

src/translation/index.tsx

@@ -14,6 +14,7 @@ import {getTranslatorLink} from '#/locale/helpers'
 import {logger} from '#/logger'
 import {useLanguagePrefs} from '#/state/preferences'
 import {useAnalytics} from '#/analytics'
+import {IS_WEB} from '#/env'
 
 type TranslationState =
   | {status: 'idle'}
@@ -119,7 +120,7 @@ export function useTranslateOnDevice() {
   return context
 }
 
-export function Provider({children}: {children?: React.ReactNode}) {
+export function Provider({children}: React.PropsWithChildren<unknown>) {
   const [translationState, setTranslationState] =
     useState<TranslationState>(IDLE)
   const openLink = useOpenLink()
@@ -158,15 +159,25 @@ export function Provider({children}: {children?: React.ReactNode}) {
           targetLanguage: result.targetLanguage,
         })
       } catch (e) {
-        logger.error('Failed to translate post on device', {safeMessage: e})
+        if (IS_WEB) {
-        // On-device translation failed (language pack missing or user dismissed
+          // Web always opens Google Translate.
-        // the download prompt). Fall back to Google Translate.
+          ax.metric('translate:result', {
-        ax.metric('translate:result', {
+            method: 'google-translate',
-          method: 'fallback-alert',
+            os: Platform.OS,
-          os: Platform.OS,
+            sourceLanguage: sourceLangCode ?? null,
-          sourceLanguage: sourceLangCode ?? null,
+            targetLanguage: targetLangCode,
-          targetLanguage: targetLangCode,
+          })
-        })
+        } else {
+          logger.error('Failed to translate post on device', {safeMessage: e})
+          // On-device translation failed (language pack missing or user dismissed
+          // the download prompt). Fall back to Google Translate.
+          ax.metric('translate:result', {
+            method: 'fallback-alert',
+            os: Platform.OS,
+            sourceLanguage: sourceLangCode ?? null,
+            targetLanguage: targetLangCode,
+          })
+        }
         setTranslationState({status: 'idle'})
         const translateUrl = getTranslatorLink(
           text,

src/translation/index.web.tsx

@@ -1,43 +0,0 @@
-import {useCallback} from 'react'
-import {Platform} from 'react-native'
-
-import {useOpenLink} from '#/lib/hooks/useOpenLink'
-import {getTranslatorLink} from '#/locale/helpers'
-import {useLanguagePrefs} from '#/state/preferences'
-import {useAnalytics} from '#/analytics'
-
-const translationState = {status: 'idle'} // No on-device translations for web.
-
-const clearTranslation = () => {} // no-op on web
-
-/**
- * Web always opens Google Translate.
- */
-export function useTranslateOnDevice() {
-  const openLink = useOpenLink()
-  const ax = useAnalytics()
-  const {primaryLanguage} = useLanguagePrefs()
-
-  const translate = useCallback(
-    async (
-      text: string,
-      targetLangCode: string = primaryLanguage,
-      sourceLangCode: string,
-    ) => {
-      const translateUrl = getTranslatorLink(
-        text,
-        targetLangCode,
-        sourceLangCode,
-      )
-      ax.metric('translate:result', {
-        method: 'google-translate',
-        os: Platform.OS,
-        sourceLanguage: sourceLangCode ?? null,
-        targetLanguage: targetLangCode,
-      })
-      await openLink(translateUrl)
-    },
-    [ax, openLink, primaryLanguage],
-  )
-  return {clearTranslation, translate, translationState}
-}