Push notification fixes (#210)

* Fix to when screen analytics events are firing

* Fix: dont trigger update state when backgrounded

* Small fix to notifee API usage

* Fix: properly load notification info for push card

src/view/com/posts/Feed.tsx

@@ -37,13 +37,9 @@ export const Feed = observer(function Feed({
   testID?: string
   headerOffset?: number
 }) {
-  const {screen, track} = useAnalytics()
+  const {track} = useAnalytics()
   const [isRefreshing, setIsRefreshing] = React.useState(false)
 
-  React.useEffect(() => {
-    screen('Feed')
-  }, [screen])
-
   // TODO optimize renderItem or FeedItem, we're getting this notice from RN: -prf
   //   VirtualizedList: You have a large list that is slow to update - make sure your
   //   renderItem function renders components that follow React performance best practices

src/view/screens/Home.tsx

@@ -21,7 +21,7 @@ const HITSLOP = {left: 20, top: 20, right: 20, bottom: 20}
 export const Home = observer(function Home({navIdx, visible}: ScreenParams) {
   const store = useStores()
   const onMainScroll = useOnMainScroll(store)
-  const {track} = useAnalytics()
+  const {screen, track} = useAnalytics()
   const safeAreaInsets = useSafeAreaInsets()
   const scrollElRef = React.useRef<FlatList>(null)
   const [wasVisible, setWasVisible] = React.useState<boolean>(false)
@@ -59,6 +59,9 @@ export const Home = observer(function Home({navIdx, visible}: ScreenParams) {
       feedCleanup()
     }
 
+    // guard to only continue when transitioning from !visible -> visible
+    // TODO is this 100% needed? depends on if useEffect() is getting refired
+    //      for reasons other than `visible` changing -prf
     if (!visible) {
       setWasVisible(false)
       return cleanup
@@ -67,6 +70,8 @@ export const Home = observer(function Home({navIdx, visible}: ScreenParams) {
     }
     setWasVisible(true)
 
+    // just became visible
+    screen('Feed')
     store.nav.setTitle(navIdx, 'Home')
     store.log.debug('Updating home feed')
     if (store.me.mainFeed.hasContent) {
@@ -75,7 +80,7 @@ export const Home = observer(function Home({navIdx, visible}: ScreenParams) {
       store.me.mainFeed.setup()
     }
     return cleanup
-  }, [visible, store, store.me.mainFeed, navIdx, doPoll, wasVisible, scrollToTop])
+  }, [visible, store, store.me.mainFeed, navIdx, doPoll, wasVisible, scrollToTop, screen])
 
   const onPressCompose = (imagesOpen?: boolean) => {
     track('Home:ComposeButtonPressed')

src/view/screens/Notifications.tsx

@@ -14,10 +14,6 @@ export const Notifications = ({navIdx, visible}: ScreenParams) => {
   const scrollElRef = React.useRef<FlatList>(null)
   const {screen} = useAnalytics()
 
-  useEffect(() => {
-    screen('Notifications')
-  }, [screen])
-
   const onSoftReset = () => {
     scrollElRef.current?.scrollToOffset({offset: 0})
   }
@@ -34,9 +30,10 @@ export const Notifications = ({navIdx, visible}: ScreenParams) => {
     store.me.notifications.update().then(() => {
       store.me.notifications.updateReadState()
     })
+    screen('Notifications')
     store.nav.setTitle(navIdx, 'Notifications')
     return cleanup
-  }, [visible, store, navIdx])
+  }, [visible, store, navIdx, screen])
 
   const onPressTryAgain = () => {
     store.me.notifications.refresh()