From 8ccffd654237aecc2b9b163fc042265b2aa28caf Mon Sep 17 00:00:00 2001 From: Eric Bailey Date: Tue, 22 Jul 2025 18:02:44 -0500 Subject: [PATCH] Prefix Bitdrift key with EXPO_PUBLIC --- .env.example | 2 +- .github/workflows/build-submit-android.yml | 2 +- .github/workflows/build-submit-ios.yml | 2 +- .github/workflows/bundle-deploy-eas-update.yml | 6 +++--- docs/build.md | 4 ++-- src/env.ts | 3 ++- 6 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.env.example b/.env.example index 844919a5be..0502fab41d 100644 --- a/.env.example +++ b/.env.example @@ -37,7 +37,7 @@ SENTRY_DIST=test SENTRY_RELEASE=dev # Bitdrift API key. If undefined, Bitdrift will be disabled. -BITDRIFT_API_KEY= +EXPO_PUBLIC_BITDRIFT_API_KEY= # # diff --git a/.github/workflows/build-submit-android.yml b/.github/workflows/build-submit-android.yml index f75c95052e..e497d74175 100644 --- a/.github/workflows/build-submit-android.yml +++ b/.github/workflows/build-submit-android.yml @@ -67,7 +67,7 @@ jobs: echo "${{ secrets.ENV_TOKEN }}" > .env echo "EXPO_PUBLIC_BUNDLE_IDENTIFIER=$(git rev-parse --short HEAD)" >> .env echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env - echo "BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env echo "$json" > google-services.json - name: Setup Sentry vars for build-time injection diff --git a/.github/workflows/build-submit-ios.yml b/.github/workflows/build-submit-ios.yml index dd7c5f85b5..3998f71b7d 100644 --- a/.github/workflows/build-submit-ios.yml +++ b/.github/workflows/build-submit-ios.yml @@ -79,7 +79,7 @@ jobs: echo "${{ secrets.ENV_TOKEN }}" > .env echo "EXPO_PUBLIC_BUNDLE_IDENTIFIER=$(git rev-parse --short HEAD)" >> .env echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env - echo "BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env echo "${{ secrets.GOOGLE_SERVICES_TOKEN }}" > google-services.json - name: Setup Sentry vars for build-time injection diff --git a/.github/workflows/bundle-deploy-eas-update.yml b/.github/workflows/bundle-deploy-eas-update.yml index 5a4702f964..b462bf8fe3 100644 --- a/.github/workflows/bundle-deploy-eas-update.yml +++ b/.github/workflows/bundle-deploy-eas-update.yml @@ -107,7 +107,7 @@ jobs: echo "${{ secrets.ENV_TOKEN }}" > .env echo "EXPO_PUBLIC_BUNDLE_IDENTIFIER=$(git rev-parse --short HEAD)" >> .env echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env - echo "BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env echo "$json" > google-services.json - name: Setup Sentry vars for build-time injection @@ -209,7 +209,7 @@ jobs: echo "${{ secrets.ENV_TOKEN }}" > .env echo "EXPO_PUBLIC_BUNDLE_IDENTIFIER=$(git rev-parse --short HEAD)" >> .env echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env - echo "BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env echo "${{ secrets.GOOGLE_SERVICES_TOKEN }}" > google-services.json - name: 🏗️ EAS Build @@ -287,7 +287,7 @@ jobs: echo "${{ secrets.ENV_TOKEN }}" > .env echo "EXPO_PUBLIC_BUNDLE_IDENTIFIER=$(git rev-parse --short HEAD)" >> .env echo "EXPO_PUBLIC_BUNDLE_DATE=$(date -u +"%y%m%d%H")" >> .env - echo "BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env + echo "EXPO_PUBLIC_BITDRIFT_API_KEY=${{ secrets.BITDRIFT_API_KEY }}" >> .env echo "$json" > google-services.json - name: 🏗️ EAS Build diff --git a/docs/build.md b/docs/build.md index 7817dd0957..87b653bdb9 100644 --- a/docs/build.md +++ b/docs/build.md @@ -89,9 +89,9 @@ If you change `SENTRY_AUTH_TOKEN`, you need to do `yarn prebuild` before running ### Adding bitdrift -Adding bitdirft is NOT required. You can keep `BITDRIFT_API_KEY=` in `.env` which will avoid initializing bitdrift during startup. +Adding bitdrift is NOT required. You can keep `EXPO_PUBLIC_BITDRIFT_API_KEY=` in `.env` which will avoid initializing bitdrift during startup. -However, if you're a part of the Bluesky team and want to enable bitdrift, fill in `BITDRIFT_API_KEY` in your `.env` to enable bitdrift. +However, if you're a part of the Bluesky team and want to enable bitdrift, fill in `EXPO_PUBLIC_BITDRIFT_API_KEY` in your `.env` to enable bitdrift. ### Adding and Updating Locales diff --git a/src/env.ts b/src/env.ts index 5e99e31109..cfa71a198b 100644 --- a/src/env.ts +++ b/src/env.ts @@ -78,4 +78,5 @@ export const SENTRY_DIST: string = process.env.SENTRY_DIST || 'dev' /** * Bitdrift API key. If undefined, Bitdrift should be disabled. */ -export const BITDRIFT_API_KEY: string | undefined = process.env.BITDRIFT_API_KEY +export const BITDRIFT_API_KEY: string | undefined = + process.env.EXPO_PUBLIC_BITDRIFT_API_KEY