simplify pressable changes

This commit is contained in:
Hailey
2024-10-02 10:56:19 -07:00
parent b0c0aee904
commit 84d32e3a95
6 changed files with 144 additions and 9 deletions
+12
View File
@@ -0,0 +1,12 @@
import React from 'react'
import {Button, ButtonProps} from '#/components/Button'
import {NormalizedPressable} from '#/components/NormalizedPressable'
export function BottomSheetButton({children, ...rest}: ButtonProps) {
return (
<Button {...rest} Component={NormalizedPressable}>
{children}
</Button>
)
}
+4 -2
View File
@@ -87,6 +87,7 @@ export type ButtonProps = Pick<
style?: StyleProp<ViewStyle> style?: StyleProp<ViewStyle>
hoverStyle?: StyleProp<ViewStyle> hoverStyle?: StyleProp<ViewStyle>
children: NonTextElements | ((context: ButtonContext) => NonTextElements) children: NonTextElements | ((context: ButtonContext) => NonTextElements)
Component?: React.ComponentType<PressableProps>
} }
export type ButtonTextProps = TextProps & VariantProps & {disabled?: boolean} export type ButtonTextProps = TextProps & VariantProps & {disabled?: boolean}
@@ -114,6 +115,7 @@ export const Button = React.forwardRef<View, ButtonProps>(
disabled = false, disabled = false,
style, style,
hoverStyle: hoverStyleProp, hoverStyle: hoverStyleProp,
Component = Pressable,
...rest ...rest
}, },
ref, ref,
@@ -449,7 +451,7 @@ export const Button = React.forwardRef<View, ButtonProps>(
const flattenedBaseStyles = flatten([baseStyles, style]) const flattenedBaseStyles = flatten([baseStyles, style])
return ( return (
<Pressable <Component
role="button" role="button"
accessibilityHint={undefined} // optional accessibilityHint={undefined} // optional
{...rest} {...rest}
@@ -500,7 +502,7 @@ export const Button = React.forwardRef<View, ButtonProps>(
<Context.Provider value={context}> <Context.Provider value={context}>
{typeof children === 'function' ? children(context) : children} {typeof children === 'function' ? children(context) : children}
</Context.Provider> </Context.Provider>
</Pressable> </Component>
) )
}, },
) )
+3 -3
View File
@@ -1,6 +1,5 @@
import React from 'react' import React from 'react'
import {StyleProp, View, ViewStyle} from 'react-native' import {StyleProp, View, ViewStyle} from 'react-native'
import {BlueskyBottomSheetPressable as Pressable} from '@haileyok/bluesky-bottom-sheet'
import {msg, Trans} from '@lingui/macro' import {msg, Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react' import {useLingui} from '@lingui/react'
import flattenReactChildren from 'react-keyed-flatten-children' import flattenReactChildren from 'react-keyed-flatten-children'
@@ -19,6 +18,7 @@ import {
ItemTextProps, ItemTextProps,
TriggerProps, TriggerProps,
} from '#/components/Menu/types' } from '#/components/Menu/types'
import {NormalizedPressable} from '#/components/NormalizedPressable'
import {Text} from '#/components/Typography' import {Text} from '#/components/Typography'
export { export {
@@ -117,7 +117,7 @@ export function Item({children, label, style, onPress, ...rest}: ItemProps) {
} = useInteractionState() } = useInteractionState()
return ( return (
<Pressable <NormalizedPressable
{...rest} {...rest}
accessibilityHint="" accessibilityHint=""
accessibilityLabel={label} accessibilityLabel={label}
@@ -151,7 +151,7 @@ export function Item({children, label, style, onPress, ...rest}: ItemProps) {
<ItemContext.Provider value={{disabled: Boolean(rest.disabled)}}> <ItemContext.Provider value={{disabled: Boolean(rest.disabled)}}>
{children} {children}
</ItemContext.Provider> </ItemContext.Provider>
</Pressable> </NormalizedPressable>
) )
} }
+2 -4
View File
@@ -4,8 +4,6 @@ import {
GestureResponderEvent, GestureResponderEvent,
PressableProps, PressableProps,
} from 'react-native' } from 'react-native'
import {PressableEvent} from 'react-native-gesture-handler/lib/typescript/components/Pressable/PressableProps'
import {BueskyBottomSheetPressableProps} from '@haileyok/bluesky-bottom-sheet'
import {TextStyleProp, ViewStyleProp} from '#/alf' import {TextStyleProp, ViewStyleProp} from '#/alf'
import * as Dialog from '#/components/Dialog' import * as Dialog from '#/components/Dialog'
@@ -89,10 +87,10 @@ export type TriggerChildProps =
} }
export type ItemProps = React.PropsWithChildren< export type ItemProps = React.PropsWithChildren<
Omit<BueskyBottomSheetPressableProps, 'style'> & Omit<PressableProps, 'style'> &
ViewStyleProp & { ViewStyleProp & {
label: string label: string
onPress: (e: PressableEvent | GestureResponderEvent) => void onPress: (e: GestureResponderEvent) => void
} }
> >
+120
View File
@@ -0,0 +1,120 @@
import React from 'react'
import {
GestureResponderEvent,
NativeMouseEvent,
NativeSyntheticEvent,
PressableProps,
View,
} from 'react-native'
import {Pressable as BSPressable} from 'react-native-gesture-handler'
import {PressableEvent} from 'react-native-gesture-handler/lib/typescript/components/Pressable/PressableProps'
function pressableEventToGestureResponderEvent(
event: PressableEvent,
): GestureResponderEvent {
return {
nativeEvent: {
...event.nativeEvent,
touches: [],
changedTouches: [],
identifier: event.nativeEvent.identifier.toString(),
target: event.nativeEvent.target.toString(),
},
target: null,
currentTarget: null,
preventDefault() {},
stopPropagation() {},
cancelable: false,
defaultPrevented: false,
eventPhase: 0,
isTrusted: false,
bubbles: false,
timeStamp: event.nativeEvent.timestamp,
isDefaultPrevented(): boolean {
return false
},
isPropagationStopped(): boolean {
return false
},
persist() {},
type: 'press',
}
}
function pressableEventToMouseEvent(
event: PressableEvent,
): MouseEvent & NativeSyntheticEvent<NativeMouseEvent> {
return {
...event.nativeEvent,
target: null,
currentTarget: null,
preventDefault() {},
stopPropagation() {},
cancelable: false,
defaultPrevented: false,
eventPhase: 0,
isTrusted: false,
bubbles: false,
timeStamp: event.nativeEvent.timestamp,
}
}
export const NormalizedPressable = React.forwardRef<View, PressableProps>(
function NormalizedPressable(
{
onPress,
onLongPress,
onPressIn,
onPressOut,
onHoverIn,
onHoverOut,
onFocus: _onFocus,
...rest
},
ref,
) {
const onNormalizedPress = (event: PressableEvent) => {
if (!onPress) return
onPress(pressableEventToGestureResponderEvent(event))
}
const onNormalizedLongPress = (event: PressableEvent) => {
if (!onLongPress) return
onLongPress(pressableEventToGestureResponderEvent(event))
}
const onNormalizedPressIn = (event: PressableEvent) => {
if (!onPressIn) return
onPressIn(pressableEventToGestureResponderEvent(event))
}
const onNormalizedPressOut = (event: PressableEvent) => {
if (!onPressOut) return
onPressOut(pressableEventToGestureResponderEvent(event))
}
const onNormalizedHoverIn = (event: PressableEvent) => {
if (!onHoverIn) return
onHoverIn(pressableEventToMouseEvent(event))
}
const onNormalizedHoverOut = (event: PressableEvent) => {
if (!onHoverOut) return
onHoverOut(pressableEventToMouseEvent(event))
}
return (
<View ref={ref}>
<BSPressable
onPress={onNormalizedPress}
onLongPress={onNormalizedLongPress}
onPressIn={onNormalizedPressIn}
onPressOut={onNormalizedPressOut}
onHoverIn={onNormalizedHoverIn}
onHoverOut={onNormalizedHoverOut}
{...rest}
/>
</View>
)
},
)
@@ -0,0 +1,3 @@
import {Pressable as NormalizedPressable} from 'react-native'
export {NormalizedPressable}