Fix focus ring shapes (#9005)

* fix user avis being the wrong shape

* fix the fab being the wrong shape
This commit is contained in:
Samuel Newman
2025-09-09 18:40:19 +03:00
committed by GitHub
parent 53e43a957c
commit 7574a745d1
2 changed files with 24 additions and 11 deletions
+13 -7
View File
@@ -1,4 +1,4 @@
import React, {memo, useCallback, useMemo, useState} from 'react' import {memo, useCallback, useMemo, useState} from 'react'
import { import {
Image, Image,
Pressable, Pressable,
@@ -363,7 +363,7 @@ let EditableUserAvatar = ({
} }
}, [circular, size]) }, [circular, size])
const onOpenCamera = React.useCallback(async () => { const onOpenCamera = useCallback(async () => {
if (!(await requestCameraAccessIfNeeded())) { if (!(await requestCameraAccessIfNeeded())) {
return return
} }
@@ -377,7 +377,7 @@ let EditableUserAvatar = ({
) )
}, [onSelectNewAvatar, requestCameraAccessIfNeeded]) }, [onSelectNewAvatar, requestCameraAccessIfNeeded])
const onOpenLibrary = React.useCallback(async () => { const onOpenLibrary = useCallback(async () => {
if (!(await requestPhotoAccessIfNeeded())) { if (!(await requestPhotoAccessIfNeeded())) {
return return
} }
@@ -421,7 +421,7 @@ let EditableUserAvatar = ({
circular, circular,
]) ])
const onRemoveAvatar = React.useCallback(() => { const onRemoveAvatar = useCallback(() => {
onSelectNewAvatar(null) onSelectNewAvatar(null)
}, [onSelectNewAvatar]) }, [onSelectNewAvatar])
@@ -528,7 +528,7 @@ let PreviewableUserAvatar = ({
disableNavigation, disableNavigation,
onBeforePress, onBeforePress,
live, live,
...rest ...props
}: PreviewableUserAvatarProps): React.ReactNode => { }: PreviewableUserAvatarProps): React.ReactNode => {
const {_} = useLingui() const {_} = useLingui()
const queryClient = useQueryClient() const queryClient = useQueryClient()
@@ -557,10 +557,15 @@ let PreviewableUserAvatar = ({
moderation={moderation} moderation={moderation}
type={profile.associated?.labeler ? 'labeler' : 'user'} type={profile.associated?.labeler ? 'labeler' : 'user'}
live={status.isActive || live} live={status.isActive || live}
{...rest} {...props}
/> />
) )
const linkStyle =
props.type !== 'algo' && props.type !== 'list'
? a.rounded_full
: {borderRadius: props.size > 32 ? 8 : 3}
return ( return (
<ProfileHoverCard did={profile.did} disable={disableHoverCard}> <ProfileHoverCard did={profile.did} disable={disableHoverCard}>
{disableNavigation ? ( {disableNavigation ? (
@@ -596,7 +601,8 @@ let PreviewableUserAvatar = ({
did: profile.did, did: profile.did,
handle: profile.handle, handle: profile.handle,
})} })}
onPress={onPress}> onPress={onPress}
style={linkStyle}>
{avatarEl} {avatarEl}
</Link> </Link>
)} )}
+11 -4
View File
@@ -1,5 +1,10 @@
import {type ComponentProps, type JSX} from 'react' import {type ComponentProps, type JSX} from 'react'
import {StyleSheet, type TouchableWithoutFeedback} from 'react-native' import {
type Pressable,
type StyleProp,
StyleSheet,
type ViewStyle,
} from 'react-native'
import Animated from 'react-native-reanimated' import Animated from 'react-native-reanimated'
import {useSafeAreaInsets} from 'react-native-safe-area-context' import {useSafeAreaInsets} from 'react-native-safe-area-context'
import {LinearGradient} from 'expo-linear-gradient' import {LinearGradient} from 'expo-linear-gradient'
@@ -12,14 +17,15 @@ import {clamp} from '#/lib/numbers'
import {gradients} from '#/lib/styles' import {gradients} from '#/lib/styles'
import {isWeb} from '#/platform/detection' import {isWeb} from '#/platform/detection'
import {ios} from '#/alf' import {ios} from '#/alf'
import {atoms as a} from '#/alf'
export interface FABProps export interface FABProps extends ComponentProps<typeof Pressable> {
extends ComponentProps<typeof TouchableWithoutFeedback> {
testID?: string testID?: string
icon: JSX.Element icon: JSX.Element
style?: StyleProp<ViewStyle>
} }
export function FABInner({testID, icon, onPress, ...props}: FABProps) { export function FABInner({testID, icon, onPress, style, ...props}: FABProps) {
const insets = useSafeAreaInsets() const insets = useSafeAreaInsets()
const {isMobile, isTablet} = useWebMediaQueries() const {isMobile, isTablet} = useWebMediaQueries()
const playHaptic = useHaptics() const playHaptic = useHaptics()
@@ -51,6 +57,7 @@ export function FABInner({testID, icon, onPress, ...props}: FABProps) {
playHaptic('Heavy') playHaptic('Heavy')
})} })}
targetScale={0.9} targetScale={0.9}
style={[a.rounded_full, style]}
{...props}> {...props}>
<LinearGradient <LinearGradient
colors={[gradients.blueLight.start, gradients.blueLight.end]} colors={[gradients.blueLight.start, gradients.blueLight.end]}