diff --git a/src/alf/atoms.ts b/src/alf/atoms.ts index 5b7c5c87ea..1878235466 100644 --- a/src/alf/atoms.ts +++ b/src/alf/atoms.ts @@ -363,6 +363,14 @@ export const atoms = { border_r_0: { borderRightWidth: 0, }, + border_x_0: { + borderLeftWidth: 0, + borderRightWidth: 0, + }, + border_y_0: { + borderTopWidth: 0, + borderBottomWidth: 0, + }, border: { borderWidth: StyleSheet.hairlineWidth, }, @@ -378,6 +386,14 @@ export const atoms = { border_r: { borderRightWidth: StyleSheet.hairlineWidth, }, + border_x: { + borderLeftWidth: StyleSheet.hairlineWidth, + borderRightWidth: StyleSheet.hairlineWidth, + }, + border_y: { + borderTopWidth: StyleSheet.hairlineWidth, + borderBottomWidth: StyleSheet.hairlineWidth, + }, border_transparent: { borderColor: 'transparent', }, diff --git a/src/logger/metrics.ts b/src/logger/metrics.ts index 6e65845ca1..c1f41f78ad 100644 --- a/src/logger/metrics.ts +++ b/src/logger/metrics.ts @@ -258,7 +258,11 @@ export type MetricEvents = { position: number } 'suggestedUser:press': { - logContext: 'Explore' | 'InterstitialDiscover' | 'InterstitialProfile' + logContext: + | 'Explore' + | 'InterstitialDiscover' + | 'InterstitialProfile' + | 'Onboarding' recId?: number position: number } diff --git a/src/screens/Onboarding/StepSuggestedAccounts/index.tsx b/src/screens/Onboarding/StepSuggestedAccounts/index.tsx index ed0bd46aa3..d3e0587fcc 100644 --- a/src/screens/Onboarding/StepSuggestedAccounts/index.tsx +++ b/src/screens/Onboarding/StepSuggestedAccounts/index.tsx @@ -8,6 +8,7 @@ import * as bcp47Match from 'bcp-47-match' import {isBlockedOrBlocking, isMuted} from '#/lib/moderation/blocked-and-muted' import {logger} from '#/logger' +import {isWeb} from '#/platform/detection' import {updateProfileShadow} from '#/state/cache/profile-shadow' import {useLanguagePrefs} from '#/state/preferences' import {useModerationOpts} from '#/state/preferences/moderation-opts' @@ -140,22 +141,28 @@ export function StepSuggestedAccounts() { return ( - Suggested Accounts + Suggested for you {isLoading || !moderationOpts ? ( @@ -183,8 +190,9 @@ export function StepSuggestedAccounts() { style={[ a.flex_1, a.mt_md, - a.border_b, + a.border_y, t.atoms.border_contrast_low, + isWeb && [a.border_x, a.rounded_sm, a.overflow_hidden], ]}> {suggestedUsers?.actors.map((user, index) => ( @@ -310,9 +316,9 @@ function SuggestedProfileCard({ logger.metric( 'suggestedUser:follow', { - logContext: 'Explore', + logContext: 'Onboarding', location: 'Card', - recId, + recId: undefined, position, }, {statsig: true}, @@ -320,7 +326,7 @@ function SuggestedProfileCard({ }} /> - + diff --git a/src/screens/Search/modules/ExploreSuggestedAccounts.tsx b/src/screens/Search/modules/ExploreSuggestedAccounts.tsx index b217b6b844..d18a59d96d 100644 --- a/src/screens/Search/modules/ExploreSuggestedAccounts.tsx +++ b/src/screens/Search/modules/ExploreSuggestedAccounts.tsx @@ -60,6 +60,7 @@ export function SuggestedAccountsTabBar({ selectedInterest, onSelectInterest, hideDefaultTab, + defaultTabLabel, priorityInterests, leftPadding = tokens.space.md, logContext = 'Explore', @@ -68,6 +69,7 @@ export function SuggestedAccountsTabBar({ onSelectInterest: (interest: string | null) => void priorityInterests?: string[] hideDefaultTab?: boolean + defaultTabLabel?: string leftPadding?: number logContext?: 'Explore' | 'Onboarding' }) { @@ -108,7 +110,7 @@ export function SuggestedAccountsTabBar({ hideDefaultTab ? interestsDisplayNames : { - all: _(msg`For You`), + all: defaultTabLabel || _(msg`For You`), ...interestsDisplayNames, } }