From 72c6115d6af61d62edf711b7eb396a52a6fd09f2 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Fri, 12 Jun 2026 16:04:19 +0300 Subject: [PATCH] tighten AvatarBubbles profiles type to non-nullable Now that the count prop drives placeholder slots, callers no longer need to pad the profiles array with undefined, so the prop can be AnyProfileView[]. Drops the now-dead falsy check in the self-filter and the defensive ?? undefined at the one call site that had it. Co-Authored-By: Claude Fable 5 --- src/components/AvatarBubbles.tsx | 4 ++-- src/screens/Messages/components/OutgoingRequestListItem.tsx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/AvatarBubbles.tsx b/src/components/AvatarBubbles.tsx index c6672e8e6a..49ac4d006f 100644 --- a/src/components/AvatarBubbles.tsx +++ b/src/components/AvatarBubbles.tsx @@ -34,7 +34,7 @@ export function AvatarBubbles({ count, }: { animate?: boolean - profiles: (bsky.profile.AnyProfileView | undefined)[] + profiles: bsky.profile.AnyProfileView[] /** * By default, when there are more than 2 profiles, the current user is * filtered out (so you don't see yourself among your own group's members). @@ -54,7 +54,7 @@ export function AvatarBubbles({ const {currentAccount} = useSession() const profiles = !self && allProfiles.length > 2 - ? allProfiles.filter(p => !p || p.did !== currentAccount?.did) + ? allProfiles.filter(p => p.did !== currentAccount?.did) : allProfiles const bubbleCount = Math.max(profiles.length, count ?? 0) diff --git a/src/screens/Messages/components/OutgoingRequestListItem.tsx b/src/screens/Messages/components/OutgoingRequestListItem.tsx index 1b601779a6..b5dcdf08df 100644 --- a/src/screens/Messages/components/OutgoingRequestListItem.tsx +++ b/src/screens/Messages/components/OutgoingRequestListItem.tsx @@ -63,7 +63,7 @@ export function OutgoingRequestListItem({ (hovered || pressed || focused) && t.atoms.bg_contrast_25, ]}>