classify migrated chat group errors with matchXrpcError

The lex client throws XrpcResponseError, which is not an XRPCError
subclass, so the per-method error classes generated by @atproto/api no
longer match. Those instanceof checks compile fine but silently stop
firing, degrading every typed group failure to the generic fallback
message. Narrow against the method schema instead.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

src/components/dms/dialogs/NewChatDialog.tsx

@@ -1,5 +1,4 @@
 import {useCallback} from 'react'
-import {ChatBskyGroupCreateGroup} from '@atproto/api'
 import {Trans, useLingui} from '@lingui/react/macro'
 
 import {useRequireEmailVerification} from '#/lib/hooks/useRequireEmailVerification'
@@ -88,29 +87,27 @@ export function NewChat({
       let errorMessage = l`An issue occurred starting the group chat, please try again.`
       if (isNetworkError(error)) {
         errorMessage = l`A network error occurred. Please check your internet connection.`
-      } else if (
+      } else {
-        error instanceof ChatBskyGroupCreateGroup.AccountSuspendedError
+        switch (matchXrpcError(error, chat.bsky.group.createGroup)) {
-      ) {
+          case 'AccountSuspended':
-        errorMessage = l`Suspended accounts cannot participate in a group chat.`
+            errorMessage = l`Suspended accounts cannot participate in a group chat.`
-      } else if (error instanceof ChatBskyGroupCreateGroup.BlockedActorError) {
+            break
-        errorMessage = l`One of the selected recipients has blocked you and cannot be messaged.`
+          case 'BlockedActor':
-      } else if (
+            errorMessage = l`One of the selected recipients has blocked you and cannot be messaged.`
-        error instanceof
+            break
-        ChatBskyGroupCreateGroup.NewAccountCannotCreateGroupError
+          case 'NewAccountCannotCreateGroup':
-      ) {
+            errorMessage = l`You cannot create a group chat yet.`
-        errorMessage = l`You cannot create a group chat yet.`
+            break
-      } else if (
+          case 'NotFollowedBySender':
-        error instanceof ChatBskyGroupCreateGroup.NotFollowedBySenderError
+            errorMessage = l`A selected recipient is not followed by the sender.`
-      ) {
+            break
-        errorMessage = l`A selected recipient is not followed by the sender.`
+          case 'RecipientNotFound':
-      } else if (
+            errorMessage = l`Unable to find a selected recipient.`
-        error instanceof ChatBskyGroupCreateGroup.RecipientNotFoundError
+            break
-      ) {
+          case 'UserForbidsGroups':
-        errorMessage = l`Unable to find a selected recipient.`
+            errorMessage = l`One of the selected recipients does not allow group chats.`
-      } else if (
+            break
-        error instanceof ChatBskyGroupCreateGroup.UserForbidsGroupsError
+        }
-      ) {
-        errorMessage = l`One of the selected recipients does not allow group chats.`
       }
       Toast.show(errorMessage, {
         type: 'error',

src/components/dms/dialogs/ShareViaChatDialog.tsx

@@ -1,5 +1,4 @@
 import {useCallback, useState} from 'react'
-import {ChatBskyGroupCreateGroup} from '@atproto/api'
 import {useLingui} from '@lingui/react/macro'
 
 import {isNetworkError} from '#/lib/strings/errors'
@@ -104,29 +103,27 @@ function SendViaChatDialogInner({
       let errorMessage = l`An issue occurred starting the group chat, please try again.`
       if (isNetworkError(error)) {
         errorMessage = l`A network error occurred. Please check your internet connection.`
-      } else if (
+      } else {
-        error instanceof ChatBskyGroupCreateGroup.AccountSuspendedError
+        switch (matchXrpcError(error, chat.bsky.group.createGroup)) {
-      ) {
+          case 'AccountSuspended':
-        errorMessage = l`Suspended accounts cannot participate in a group chat.`
+            errorMessage = l`Suspended accounts cannot participate in a group chat.`
-      } else if (error instanceof ChatBskyGroupCreateGroup.BlockedActorError) {
+            break
-        errorMessage = l`One of the selected recipients has blocked you and cannot be messaged.`
+          case 'BlockedActor':
-      } else if (
+            errorMessage = l`One of the selected recipients has blocked you and cannot be messaged.`
-        error instanceof
+            break
-        ChatBskyGroupCreateGroup.NewAccountCannotCreateGroupError
+          case 'NewAccountCannotCreateGroup':
-      ) {
+            errorMessage = l`You cannot create a group chat yet.`
-        errorMessage = l`You cannot create a group chat yet.`
+            break
-      } else if (
+          case 'NotFollowedBySender':
-        error instanceof ChatBskyGroupCreateGroup.NotFollowedBySenderError
+            errorMessage = l`A selected recipient is not followed by the sender.`
-      ) {
+            break
-        errorMessage = l`A selected recipient is not followed by the sender.`
+          case 'RecipientNotFound':
-      } else if (
+            errorMessage = l`Unable to find a selected recipient.`
-        error instanceof ChatBskyGroupCreateGroup.RecipientNotFoundError
+            break
-      ) {
+          case 'UserForbidsGroups':
-        errorMessage = l`Unable to find a selected recipient.`
+            errorMessage = l`One of the selected recipients does not allow group chats.`
-      } else if (
+            break
-        error instanceof ChatBskyGroupCreateGroup.UserForbidsGroupsError
+        }
-      ) {
-        errorMessage = l`One of the selected recipients does not allow group chats.`
       }
       Toast.show(errorMessage, {
         type: 'error',

src/components/intents/GroupChatJoinDialog.tsx

@@ -1,11 +1,6 @@
 import {useEffect} from 'react'
 import {View} from 'react-native'
-import {
+import {ChatBskyGroupDefs, moderateProfile} from '@atproto/api'
-  ChatBskyGroupDefs,
-  ChatBskyGroupRequestJoin,
-  ChatBskyGroupWithdrawJoinRequest,
-  moderateProfile,
-} from '@atproto/api'
 import {Plural, Trans, useLingui} from '@lingui/react/macro'
 import {useNavigation} from '@react-navigation/native'
 import {useQueryClient} from '@tanstack/react-query'
@@ -16,6 +11,7 @@ import {makeProfileLink} from '#/lib/routes/links'
 import {type NavigationProp} from '#/lib/routes/types'
 import {isNetworkError} from '#/lib/strings/errors'
 import {sanitizeHandle} from '#/lib/strings/handles'
+import {matchXrpcError} from '#/lib/xrpc-error'
 import {logger} from '#/logger'
 import {useModerationOpts} from '#/state/preferences/moderation-opts'
 import {
@@ -49,6 +45,7 @@ import {Loader} from '#/components/Loader'
 import * as Toast from '#/components/Toast'
 import {Text} from '#/components/Typography'
 import {useAnalytics} from '#/analytics'
+import {chat} from '#/lexicons'
 import {ProfileBadges} from '../ProfileBadges'
 
 export function GroupChatJoinDialog() {
@@ -147,33 +144,37 @@ function GroupChatJoinDialogContent({code}: {code?: string}) {
         let errorMessage = l`Failed to join the group chat. Please try again.`
         if (isNetworkError(error)) {
           errorMessage = l`There was a problem with your internet connection, please try again`
-        } else if (error instanceof ChatBskyGroupRequestJoin.ConvoLockedError) {
+        } else {
-          errorMessage = l`This conversation is locked.`
+          switch (matchXrpcError(error, chat.bsky.group.requestJoin)) {
-        } else if (
+            case 'ConvoLocked':
-          error instanceof ChatBskyGroupRequestJoin.FollowRequiredError
+              errorMessage = l`This conversation is locked.`
-        ) {
+              break
-          errorMessage = l`Only followers can join this group chat.`
+            case 'FollowRequired':
-        } else if (error instanceof ChatBskyGroupRequestJoin.InvalidCodeError) {
+              errorMessage = l`Only followers can join this group chat.`
-          errorMessage = l`Invalid group chat code.`
+              break
-        } else if (
+            case 'InvalidCode':
-          error instanceof ChatBskyGroupRequestJoin.LinkDisabledError
+              errorMessage = l`Invalid group chat code.`
-        ) {
+              break
-          errorMessage = l`This invite link has been disabled.`
+            case 'LinkDisabled':
-        } else if (
+              errorMessage = l`This invite link has been disabled.`
-          error instanceof ChatBskyGroupRequestJoin.MemberLimitReachedError
+              break
-        ) {
+            case 'MemberLimitReached': {
-          errorMessage = l`The member limit has been reached.`
+              errorMessage = l`The member limit has been reached.`
-          const preview = data?.joinLinkPreviews[0]
+              const preview = data?.joinLinkPreviews[0]
-          if (
+              if (
-            ChatBskyGroupDefs.isJoinLinkPreviewView(preview) &&
+                ChatBskyGroupDefs.isJoinLinkPreviewView(preview) &&
-            preview.convo?.id
+                preview.convo?.id
-          ) {
+              ) {
-            ax.metric('groupchat:join:memberLimitReached', {
+                ax.metric('groupchat:join:memberLimitReached', {
-              convoId: preview.convo.id,
+                  convoId: preview.convo.id,
-            })
+                })
+              }
+              break
+            }
+            case 'UserKicked':
+              errorMessage = l`You have been previously removed from this group and can’t join it using this link.`
+              break
           }
-        } else if (error instanceof ChatBskyGroupRequestJoin.UserKickedError) {
-          errorMessage = l`You have been previously removed from this group and can’t join it using this link.`
         }
         Toast.show(errorMessage)
       },
@@ -194,8 +195,8 @@ function GroupChatJoinDialogContent({code}: {code?: string}) {
         if (isNetworkError(error)) {
           errorMessage = l`There was a problem with your internet connection, please try again`
         } else if (
-          error instanceof
+          matchXrpcError(error, chat.bsky.group.withdrawJoinRequest) ===
-          ChatBskyGroupWithdrawJoinRequest.InvalidJoinRequestError
+          'InvalidJoinRequest'
         ) {
           errorMessage = l`Invalid rescind request.`
         }

src/components/moderation/BlockDialog.tsx

@@ -1,6 +1,6 @@
 import {useState} from 'react'
 import {View} from 'react-native'
-import {type ChatBskyConvoDefs, ChatBskyGroupRemoveMembers} from '@atproto/api'
+import {type ChatBskyConvoDefs} from '@atproto/api'
 import {Trans, useLingui} from '@lingui/react/macro'
 import {useQueryClient} from '@tanstack/react-query'
 
@@ -309,14 +309,15 @@ function MutualGroupChat({
         let errorMessage = l`Could not remove member.`
         if (isNetworkError(error)) {
           errorMessage = l`A network error occurred. Please check your internet connection.`
-        } else if (
+        } else {
-          error instanceof ChatBskyGroupRemoveMembers.InvalidConvoError
+          switch (matchXrpcError(error, chat.bsky.group.removeMembers)) {
-        ) {
+            case 'InvalidConvo':
-          errorMessage = l`Chat not found.`
+              errorMessage = l`Chat not found.`
-        } else if (
+              break
-          error instanceof ChatBskyGroupRemoveMembers.InsufficientRoleError
+            case 'InsufficientRole':
-        ) {
+              errorMessage = l`You must be a chat owner to remove a member.`
-          errorMessage = l`You must be a chat owner to remove a member.`
+              break
+          }
         }
         Toast.show(errorMessage, {type: 'error'})
       },

src/screens/Messages/JoinRequests.tsx

@@ -1,10 +1,6 @@
 import {useState} from 'react'
 import {View} from 'react-native'
-import {
+import {type ChatBskyGroupListJoinRequests} from '@atproto/api'
-  ChatBskyGroupApproveJoinRequest,
-  type ChatBskyGroupListJoinRequests,
-  ChatBskyGroupRejectJoinRequest,
-} from '@atproto/api'
 import {Plural, Trans, useLingui} from '@lingui/react/macro'
 import {useNavigation} from '@react-navigation/native'
 import {type InfiniteData, useQueryClient} from '@tanstack/react-query'
@@ -16,6 +12,7 @@ import {
   type NativeStackScreenProps,
   type NavigationProp,
 } from '#/lib/routes/types'
+import {matchXrpcError} from '#/lib/xrpc-error'
 import {logger} from '#/logger'
 import {ConvoProvider, useConvo} from '#/state/messages/convo'
 import {ConvoStatus} from '#/state/messages/convo/types'
@@ -43,6 +40,7 @@ import * as ProfileCard from '#/components/ProfileCard'
 import * as Toast from '#/components/Toast'
 import {Text} from '#/components/Typography'
 import {useAnalytics} from '#/analytics'
+import {chat} from '#/lexicons'
 import type * as bsky from '#/types/bsky'
 import {InviteLinkDialog} from './components/InviteLinkDialog'
 
@@ -190,19 +188,18 @@ function JoinRequestsList({
         let errorMessage = l`Failed to accept join request`
         if (isNetworkError(error)) {
           errorMessage = l`A network error occurred. Please check your internet connection.`
-        } else if (
+        } else {
-          error instanceof ChatBskyGroupApproveJoinRequest.InvalidConvoError
+          switch (matchXrpcError(error, chat.bsky.group.approveJoinRequest)) {
-        ) {
+            case 'InvalidConvo':
-          errorMessage = l`Conversation not found.`
+              errorMessage = l`Conversation not found.`
-        } else if (
+              break
-          error instanceof ChatBskyGroupApproveJoinRequest.InsufficientRoleError
+            case 'InsufficientRole':
-        ) {
+              errorMessage = l`Only admins can accept join requests.`
-          errorMessage = l`Only admins can accept join requests.`
+              break
-        } else if (
+            case 'MemberLimitReached':
-          error instanceof
+              errorMessage = l`The member limit has been reached.`
-          ChatBskyGroupApproveJoinRequest.MemberLimitReachedError
+              break
-        ) {
+          }
-          errorMessage = l`The member limit has been reached.`
         }
         Toast.show(errorMessage, {type: 'error'})
       },
@@ -223,14 +220,15 @@ function JoinRequestsList({
         let errorMessage = l`Failed to reject join request`
         if (isNetworkError(error)) {
           errorMessage = l`A network error occurred. Please check your internet connection.`
-        } else if (
+        } else {
-          error instanceof ChatBskyGroupRejectJoinRequest.InvalidConvoError
+          switch (matchXrpcError(error, chat.bsky.group.rejectJoinRequest)) {
-        ) {
+            case 'InvalidConvo':
-          errorMessage = l`Conversation not found.`
+              errorMessage = l`Conversation not found.`
-        } else if (
+              break
-          error instanceof ChatBskyGroupRejectJoinRequest.InsufficientRoleError
+            case 'InsufficientRole':
-        ) {
+              errorMessage = l`Only admins can reject join requests.`
-          errorMessage = l`Only admins can reject join requests.`
+              break
+          }
         }
         Toast.show(errorMessage, {type: 'error'})
       },

src/screens/Messages/components/OutgoingRequestListItem.tsx

@@ -1,11 +1,9 @@
 import {View} from 'react-native'
-import {
+import {type ChatBskyGroupDefs} from '@atproto/api'
-  type ChatBskyGroupDefs,
-  ChatBskyGroupWithdrawJoinRequest,
-} from '@atproto/api'
 import {Trans, useLingui} from '@lingui/react/macro'
 
 import {isNetworkError} from '#/lib/strings/errors'
+import {matchXrpcError} from '#/lib/xrpc-error'
 import {useWithdrawJoinGroupChatRequest} from '#/state/queries/messages/withdraw-join-group-chat'
 import {TimeElapsed} from '#/view/com/util/TimeElapsed'
 import {atoms as a, useTheme, web} from '#/alf'
@@ -14,6 +12,7 @@ import {createStaticClick, Link} from '#/components/Link'
 import * as Prompt from '#/components/Prompt'
 import * as Toast from '#/components/Toast'
 import {Text} from '#/components/Typography'
+import {chat} from '#/lexicons'
 
 export function OutgoingRequestListItem({
   convo: convoView,
@@ -35,8 +34,8 @@ export function OutgoingRequestListItem({
         if (isNetworkError(error)) {
           errorMessage = l`There was a problem with your internet connection, please try again`
         } else if (
-          error instanceof
+          matchXrpcError(error, chat.bsky.group.withdrawJoinRequest) ===
-          ChatBskyGroupWithdrawJoinRequest.InvalidJoinRequestError
+          'InvalidJoinRequest'
         ) {
           errorMessage = l`Invalid rescind request.`
         }