Remove position: sticky from module headers because they don't work and cause a positioning issue on chrome
This commit is contained in:
@@ -737,7 +737,6 @@ export function Explore({
|
|||||||
case 'preview:header': {
|
case 'preview:header': {
|
||||||
return (
|
return (
|
||||||
<ModuleHeader.Container
|
<ModuleHeader.Container
|
||||||
headerHeight={headerHeight}
|
|
||||||
style={[a.pt_xs, a.border_b, t.atoms.border_contrast_low]}>
|
style={[a.pt_xs, a.border_b, t.atoms.border_contrast_low]}>
|
||||||
<ModuleHeader.FeedLink feed={item.feed}>
|
<ModuleHeader.FeedLink feed={item.feed}>
|
||||||
<ModuleHeader.FeedAvatar feed={item.feed} />
|
<ModuleHeader.FeedAvatar feed={item.feed} />
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ import {PressableScale} from '#/lib/custom-animations/PressableScale'
|
|||||||
import {makeCustomFeedLink} from '#/lib/routes/links'
|
import {makeCustomFeedLink} from '#/lib/routes/links'
|
||||||
import {logger} from '#/logger'
|
import {logger} from '#/logger'
|
||||||
import {UserAvatar} from '#/view/com/util/UserAvatar'
|
import {UserAvatar} from '#/view/com/util/UserAvatar'
|
||||||
import {atoms as a, native, useTheme, type ViewStyleProp, web} from '#/alf'
|
import {atoms as a, native, useTheme, type ViewStyleProp} from '#/alf'
|
||||||
import {Button, ButtonIcon} from '#/components/Button'
|
import {Button, ButtonIcon} from '#/components/Button'
|
||||||
import * as FeedCard from '#/components/FeedCard'
|
import * as FeedCard from '#/components/FeedCard'
|
||||||
import {sizes as iconSizes} from '#/components/icons/common'
|
import {sizes as iconSizes} from '#/components/icons/common'
|
||||||
@@ -17,8 +17,7 @@ import {Text, type TextProps} from '#/components/Typography'
|
|||||||
export function Container({
|
export function Container({
|
||||||
style,
|
style,
|
||||||
children,
|
children,
|
||||||
headerHeight,
|
}: {children: React.ReactNode} & ViewStyleProp) {
|
||||||
}: {children: React.ReactNode; headerHeight?: number} & ViewStyleProp) {
|
|
||||||
const t = useTheme()
|
const t = useTheme()
|
||||||
return (
|
return (
|
||||||
<View
|
<View
|
||||||
@@ -30,7 +29,6 @@ export function Container({
|
|||||||
a.pb_md,
|
a.pb_md,
|
||||||
a.gap_sm,
|
a.gap_sm,
|
||||||
t.atoms.bg,
|
t.atoms.bg,
|
||||||
headerHeight && web({position: 'sticky', top: headerHeight}),
|
|
||||||
style,
|
style,
|
||||||
]}>
|
]}>
|
||||||
{/* Very non-scientific way to avoid small gap on scroll */}
|
{/* Very non-scientific way to avoid small gap on scroll */}
|
||||||
|
|||||||
Reference in New Issue
Block a user