address re-review nits

- add fullHeight nativeOptions to match sibling list dialogs
- drop redundant variant="solid" (it's the default)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Samuel Newman
2026-06-04 12:27:00 +03:00
parent 6abd7ac5bb
commit 68c61edb32
@@ -43,7 +43,10 @@ export function UserAddRemoveListsDialog({
onRemove, onRemove,
}: UserAddRemoveListsDialogProps) { }: UserAddRemoveListsDialogProps) {
return ( return (
<Dialog.Outer control={control} testID="userAddRemoveListsDialog"> <Dialog.Outer
control={control}
testID="userAddRemoveListsDialog"
nativeOptions={{fullHeight: true}}>
<Dialog.Handle /> <Dialog.Handle />
<ListsContent profile={profile} onAdd={onAdd} onRemove={onRemove} /> <ListsContent profile={profile} onAdd={onAdd} onRemove={onRemove} />
</Dialog.Outer> </Dialog.Outer>
@@ -312,8 +315,7 @@ function ListItem({
onPress={handleToggleMembership} onPress={handleToggleMembership}
disabled={isPending} disabled={isPending}
size="tiny" size="tiny"
color={isMember ? 'secondary' : 'primary_subtle'} color={isMember ? 'secondary' : 'primary_subtle'}>
variant="solid">
{isPending && <ButtonIcon icon={Loader} />} {isPending && <ButtonIcon icon={Loader} />}
<ButtonText> <ButtonText>
{isMember ? <Trans>Remove</Trans> : <Trans>Add</Trans>} {isMember ? <Trans>Remove</Trans> : <Trans>Add</Trans>}