acetheking987/bsky-social-app
1
0
Fork 0
Code Issues Actions Packages Projects Releases 1 Wiki Activity

Fix bounce when expanding sheet on ios (#5627)

Browse Source
This commit is contained in:
Hailey
2024-10-06 12:03:06 -07:00
committed by GitHub
parent 0ebf636652
commit 686dfa5f78
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/bottom-sheet/ios/SheetView.swift
+5 -2
View File
@@ -66,6 +66,7 @@ class SheetView: ExpoView, UISheetPresentationControllerDelegate {
} }
} }
} }
private var prevLayoutDetentIdentifier: UISheetPresentationController.Detent.Identifier?
// MARK: - Lifecycle // MARK: - Lifecycle
@@ -143,11 +144,13 @@ class SheetView: ExpoView, UISheetPresentationControllerDelegate {
} }
func updateLayout() { func updateLayout() {
if let contentHeight = self.innerView?.subviews.first?.frame.size.height { if self.prevLayoutDetentIdentifier == self.selectedDetentIdentifier,
let contentHeight = self.innerView?.subviews.first?.frame.size.height {
self.sheetVc?.updateDetents(contentHeight: self.clampHeight(contentHeight), self.sheetVc?.updateDetents(contentHeight: self.clampHeight(contentHeight),
preventExpansion: self.preventExpansion) preventExpansion: self.preventExpansion)
self.selectedDetentIdentifier = self.sheetVc?.getCurrentDetentIdentifier() self.selectedDetentIdentifier = self.sheetVc?.getCurrentDetentIdentifier()
} }
self.prevLayoutDetentIdentifier = self.selectedDetentIdentifier
} }
func dismiss() { func dismiss() {
modules/bottom-sheet/ios/SheetViewController.swift
+1 -1
View File
@@ -62,7 +62,7 @@ class SheetViewController: UIViewController {
} }
} }
} }
func getCurrentDetentIdentifier() -> UISheetPresentationController.Detent.Identifier? { func getCurrentDetentIdentifier() -> UISheetPresentationController.Detent.Identifier? {
guard let sheet = self.sheetPresentationController else { guard let sheet = self.sheetPresentationController else {
return nil return nil