From 6472f955905f06fe3668879c24a3b8e6b768c091 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Wed, 18 Dec 2024 20:30:58 +0000 Subject: [PATCH] Add salt --- src/state/feed-feedback.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/state/feed-feedback.tsx b/src/state/feed-feedback.tsx index a720cd70fd..337872a32a 100644 --- a/src/state/feed-feedback.tsx +++ b/src/state/feed-feedback.tsx @@ -273,14 +273,18 @@ const m = Math.ceil((n * Math.log(p)) / Math.log(1 / Math.pow(2, Math.log(2)))) const k = Math.round((m / n) * Math.log(2)) let globalBloomFilter = new BloomFilter(m, k) +const salt = Math.random().toString(36).slice(2) + export function markGloballySeenPost(uri: string) { if (globalBloomFilter.size() >= n) { // If we ever get here, just restart to avoid saturation. globalBloomFilter = new BloomFilter(m, k) } - globalBloomFilter.add(uri) + const key = uri + salt + globalBloomFilter.add(key) } export function isLikelyGloballySeenPost(uri: string) { - return globalBloomFilter.test(uri) + const key = uri + salt + return globalBloomFilter.test(key) }