From 644c747a9538df5c168365a56f74b3ee53045f1e Mon Sep 17 00:00:00 2001
From: Eric Bailey <git@esb.lol>
Date: Thu, 31 Oct 2024 12:04:45 -0500
Subject: [PATCH] Handle errors, short posts

---
 .../util/post-embeds/ExternalLinkEmbed.tsx    | 52 ++++++++++----
 src/view/com/util/post-embeds/GithubGist.tsx  | 71 +++++++++++++------
 2 files changed, 89 insertions(+), 34 deletions(-)

diff --git a/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx b/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx
index 8053d89a65..90f1798ad8 100644
--- a/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx
+++ b/src/view/com/util/post-embeds/ExternalLinkEmbed.tsx
@@ -7,7 +7,10 @@ import {useLingui} from '@lingui/react'
 
 import {parseAltFromGIFDescription} from '#/lib/gif-alt-text'
 import {shareUrl} from '#/lib/sharing'
-import {parseEmbedPlayerFromUrl} from '#/lib/strings/embed-player'
+import {
+  EmbedPlayerParams,
+  parseEmbedPlayerFromUrl,
+} from '#/lib/strings/embed-player'
 import {toNiceDomain} from '#/lib/strings/url-helpers'
 import {isNative} from '#/platform/detection'
 import {useExternalEmbedsPrefs} from '#/state/preferences'
@@ -32,11 +35,7 @@ export const ExternalLinkEmbed = ({
   style?: StyleProp<ViewStyle>
   hideAlt?: boolean
 }) => {
-  const {_} = useLingui()
-  const t = useTheme()
   const externalEmbedPrefs = useExternalEmbedsPrefs()
-  const niceUrl = toNiceDomain(link.uri)
-  const imageUri = link.thumb
   const embedPlayerParams = React.useMemo(() => {
     const params = parseEmbedPlayerFromUrl(link.uri)
 
@@ -44,13 +43,6 @@ export const ExternalLinkEmbed = ({
       return params
     }
   }, [link.uri, externalEmbedPrefs])
-  const hasMedia = Boolean(imageUri || embedPlayerParams)
-
-  const onShareExternal = useCallback(() => {
-    if (link.uri && isNative) {
-      shareUrl(link.uri)
-    }
-  }, [link.uri])
 
   if (embedPlayerParams?.source === 'tenor') {
     const parsedAlt = parseAltFromGIFDescription(link.description)
@@ -78,6 +70,38 @@ export const ExternalLinkEmbed = ({
     )
   }
 
+  return (
+    <ExternalLinkEmbedCard
+      link={link}
+      onOpen={onOpen}
+      embedPlayerParams={embedPlayerParams}
+      style={style}
+    />
+  )
+}
+
+export function ExternalLinkEmbedCard({
+  link,
+  onOpen,
+  embedPlayerParams,
+  style,
+}: {
+  link: AppBskyEmbedExternal.ViewExternal
+  onOpen?: () => void
+  embedPlayerParams?: EmbedPlayerParams
+  style?: StyleProp<ViewStyle>
+}) {
+  const t = useTheme()
+  const {_} = useLingui()
+  const niceUrl = toNiceDomain(link.uri)
+  const hasMedia = Boolean(link.thumb || embedPlayerParams)
+
+  const onShareExternal = useCallback(() => {
+    if (link.uri && isNative) {
+      shareUrl(link.uri)
+    }
+  }, [link.uri])
+
   return (
     <Link
       label={link.title || _(msg`Open link to ${niceUrl}`)}
@@ -98,12 +122,12 @@ export const ExternalLinkEmbed = ({
               ? t.atoms.border_contrast_high
               : t.atoms.border_contrast_low,
           ]}>
-          {imageUri && !embedPlayerParams ? (
+          {link.thumb && !embedPlayerParams ? (
             <Image
               style={{
                 aspectRatio: 1.91,
               }}
-              source={{uri: imageUri}}
+              source={{uri: link.thumb}}
               accessibilityIgnoresInvertColors
             />
           ) : undefined}
diff --git a/src/view/com/util/post-embeds/GithubGist.tsx b/src/view/com/util/post-embeds/GithubGist.tsx
index 763e646b93..e52e9880d1 100644
--- a/src/view/com/util/post-embeds/GithubGist.tsx
+++ b/src/view/com/util/post-embeds/GithubGist.tsx
@@ -1,5 +1,5 @@
 import React from 'react'
-import {LayoutChangeEvent,ScrollView, View} from 'react-native'
+import {LayoutChangeEvent, ScrollView, View} from 'react-native'
 import {LinearGradient} from 'expo-linear-gradient'
 import {AppBskyEmbedExternal} from '@atproto/api'
 import {msg} from '@lingui/macro'
@@ -9,6 +9,7 @@ import {useQuery} from '@tanstack/react-query'
 import {shareUrl} from '#/lib/sharing'
 import {toNiceDomain} from '#/lib/strings/url-helpers'
 import {isNative} from '#/platform/detection'
+import {ExternalLinkEmbedCard} from '#/view/com/util/post-embeds/ExternalLinkEmbed'
 import {atoms as a, useTheme} from '#/alf'
 import {Button, ButtonIcon, ButtonText} from '#/components/Button'
 import {Divider} from '#/components/Divider'
@@ -19,6 +20,8 @@ import {Link} from '#/components/Link'
 import {Loader} from '#/components/Loader'
 import {Text} from '#/components/Typography'
 
+const MAX_HEIGHT = 400
+
 export function GithubGist({
   info,
   id,
@@ -28,10 +31,10 @@ export function GithubGist({
 }) {
   const t = useTheme()
   const {_} = useLingui()
-  const [footerHeight, setFooterHeight] = React.useState(100)
-  const [showMore, setShowMore] = React.useState(false)
+  const [footerHeight, setFooterHeight] = React.useState(97) // magic #
+  const [showMore, setShowMore] = React.useState<boolean | undefined>()
 
-  const {data: files, isLoading} = useQuery({
+  const {data: files, error} = useQuery({
     queryKey: ['gist', id],
     async queryFn() {
       const url = `https://api.github.com/gists/${id}`
@@ -62,10 +65,25 @@ export function GithubGist({
     [setFooterHeight],
   )
 
+  const onCodeLayout = React.useCallback(
+    (e: LayoutChangeEvent) => {
+      if (e.nativeEvent.layout.height < 400) {
+        setShowMore(true)
+      } else {
+        setShowMore(false)
+      }
+    },
+    [setShowMore],
+  )
+
   const onShowMore = React.useCallback(() => {
     setShowMore(true)
   }, [setShowMore])
 
+  if (error) {
+    return <ExternalLinkEmbedCard link={info} />
+  }
+
   return (
     <View
       style={[
@@ -78,16 +96,29 @@ export function GithubGist({
         t.atoms.border_contrast_low,
       ]}>
       <View style={[t.atoms.bg_contrast_25]}>
-        {isLoading || !files ? (
-          <View style={[a.px_lg]}>
+        {error ? null : !files ? ( // handled above
+          <View style={[a.p_lg]}>
             <Loader />
           </View>
         ) : (
           <View style={[a.relative]}>
             <View style={[a.relative]}>
               <ScrollView
-                style={[a.pt_lg, {maxHeight: showMore ? undefined : 500}]}>
-                <ScrollView horizontal style={[{paddingBottom: footerHeight}]}>
+                style={[
+                  a.pt_lg,
+                  {
+                    maxHeight:
+                      showMore === undefined
+                        ? MAX_HEIGHT
+                        : showMore
+                        ? undefined
+                        : MAX_HEIGHT,
+                  },
+                ]}>
+                <ScrollView
+                  horizontal
+                  style={[{paddingBottom: footerHeight}]}
+                  onLayout={onCodeLayout}>
                   <View>
                     <View
                       style={[
@@ -127,14 +158,14 @@ export function GithubGist({
                 </ScrollView>
               </ScrollView>
 
-              {!showMore && <View style={[a.absolute, a.inset_0]} />}
+              {showMore === false && <View style={[a.absolute, a.inset_0]} />}
             </View>
 
             <View
               style={[a.absolute, a.inset_0, a.p_lg, {top: 'auto'}]}
               onLayout={onFooterLayout}>
-              {!showMore && (
-                <View style={[a.absolute, a.inset_0]}>
+              <View style={[a.absolute, a.inset_0]}>
+                {showMore === false && (
                   <View
                     style={[
                       a.absolute,
@@ -163,15 +194,15 @@ export function GithubGist({
                       <ButtonIcon icon={Chevron} size="sm" position="right" />
                     </Button>
                   </View>
-                  <LinearGradient
-                    colors={['rgba(0,0,0,0)', 'rgba(0,0,0,0.5)']}
-                    locations={[0, 1]}
-                    start={{x: 0, y: 0}}
-                    end={{x: 0, y: 1}}
-                    style={[a.absolute, a.inset_0]}
-                  />
-                </View>
-              )}
+                )}
+                <LinearGradient
+                  colors={['rgba(0,0,0,0)', 'rgba(0,0,0,0.5)']}
+                  locations={[0, 1]}
+                  start={{x: 0, y: 0}}
+                  end={{x: 0, y: 1}}
+                  style={[a.absolute, a.inset_0]}
+                />
+              </View>
 
               <Link
                 label={info.title || _(msg`Open this Gist`)}