Test requiring at least one interest in onboarding (#11391)

Co-authored-by: DS Boyce <260543580+ds-boyce@users.noreply.github.com>

oxlint-suppressions.json

@@ -933,17 +933,6 @@
       "count": 1
     }
   },
-  "src/screens/Onboarding/StepInterests/index.tsx": {
-    "typescript/no-explicit-any": {
-      "count": 1
-    },
-    "typescript/no-misused-promises": {
-      "count": 1
-    },
-    "typescript/require-await": {
-      "count": 1
-    }
-  },
   "src/screens/Onboarding/StepProfile/index.tsx": {
     "typescript/no-floating-promises": {
       "count": 2

src/analytics/features/types.ts

@@ -22,6 +22,7 @@ export enum Features {
   VideoMultipartUploadEnable = 'video:multipart_upload:enable',
   SearchStarterPacksV2Enable = 'search_starter_packs_v2:enable',
   FollowSortEnable = 'follow_sort:enable',
+  OnboardingInterestsRequiredEnable = 'onboarding:interests:required:enable',
 
   // values
   TrendingDiscoverValues = 'trending_discover:values',

src/analytics/metrics/types.ts

@@ -143,6 +143,7 @@ export type Events = {
     selectedInterests: string[]
     selectedInterestsLength: number
   }
+  'onboarding:interests:disabledNextPressed': {}
   'onboarding:suggestedAccounts:tabPressed': {
     tab: string
   }

src/screens/Onboarding/StepInterests/index.tsx

@@ -1,8 +1,6 @@
 import {useCallback, useState} from 'react'
-import {View} from 'react-native'
+import {Pressable, View} from 'react-native'
-import {msg} from '@lingui/core/macro'
+import {Trans, useLingui} from '@lingui/react/macro'
-import {useLingui} from '@lingui/react'
-import {Trans} from '@lingui/react/macro'
 
 import {interests, useInterestsDisplayNames} from '#/lib/interests'
 import {capitalize} from '#/lib/strings/capitalize'
@@ -19,20 +17,36 @@ import {atoms as a} from '#/alf'
 import {Button, ButtonIcon, ButtonText} from '#/components/Button'
 import * as Toggle from '#/components/forms/Toggle'
 import {Loader} from '#/components/Loader'
+import * as Tooltip from '#/components/Tooltip'
 import {useAnalytics} from '#/analytics'
 
 export function StepInterests() {
-  const {_} = useLingui()
+  const {t: l} = useLingui()
   const ax = useAnalytics()
   const interestsDisplayNames = useInterestsDisplayNames()
 
   const {state, dispatch} = useOnboardingInternalState()
   const [saving, setSaving] = useState(false)
+  const [tooltipVisible, setTooltipVisible] = useState(false)
   const [selectedInterests, setSelectedInterests] = useState<string[]>(
     state.interestsStepResults.selectedInterests.map(i => i),
   )
+  /*
+   * Behind this gate, users must choose at least one interest before they can
+   * continue.
+   */
+  const interestRequired = ax.features.enabled(
+    ax.features.OnboardingInterestsRequiredEnable,
+  )
+  const missingRequiredInterest =
+    interestRequired && selectedInterests.length === 0
 
-  const saveInterests = useCallback(async () => {
+  const showMissingInterestTooltip = () => {
+    ax.metric('onboarding:interests:disabledNextPressed', {})
+    setTooltipVisible(true)
+  }
+
+  const saveInterests = useCallback(() => {
     setSaving(true)
 
     try {
@@ -46,12 +60,37 @@ export function StepInterests() {
         selectedInterests,
         selectedInterestsLength: selectedInterests.length,
       })
-    } catch (e: any) {
+    } catch (error) {
-      logger.info(`onboading: error saving interests`)
+      const e = error as Error
+      logger.info(`onboarding: error saving interests`)
       logger.error(e)
     }
   }, [ax, selectedInterests, setSaving, dispatch])
 
+  const continueButton = (
+    <Button
+      disabled={saving || missingRequiredInterest}
+      testID="onboardingContinue"
+      variant="solid"
+      color="primary"
+      size="large"
+      label={
+        missingRequiredInterest
+          ? l`Choose an interest`
+          : l`Continue to next step`
+      }
+      onPress={() => void saveInterests()}>
+      <ButtonText style={{pointerEvents: 'none'}}>
+        {missingRequiredInterest ? (
+          <Trans>Choose an interest</Trans>
+        ) : (
+          <Trans>Continue</Trans>
+        )}
+      </ButtonText>
+      {saving && <ButtonIcon icon={Loader} />}
+    </Button>
+  )
+
   return (
     <View style={[a.align_start, a.gap_sm]} testID="onboardingInterests">
       <OnboardingPosition />
@@ -59,14 +98,21 @@ export function StepInterests() {
         <Trans>What are your interests?</Trans>
       </OnboardingTitleText>
       <OnboardingDescriptionText>
-        <Trans>We'll use this to help customize your experience.</Trans>
+        {interestRequired ? (
+          <Trans>
+            Choose at least one. We'll use this to customize your experience.
+            You can change these anytime.
+          </Trans>
+        ) : (
+          <Trans>We'll use this to help customize your experience.</Trans>
+        )}
       </OnboardingDescriptionText>
 
       <View style={[a.w_full, a.pt_lg]}>
         <Toggle.Group
           values={selectedInterests}
           onChange={setSelectedInterests}
-          label={_(msg`Select your interests from the options below`)}>
+          label={l`Select your interests from the options below`}>
           <View style={[a.flex_row, a.gap_md, a.flex_wrap]}>
             {interests.map(interest => (
               <Toggle.Item
@@ -81,19 +127,34 @@ export function StepInterests() {
       </View>
 
       <OnboardingControls.Portal>
-        <Button
+        <View style={[a.relative]}>
-          disabled={saving}
+          {missingRequiredInterest ? (
-          testID="onboardingContinue"
+            <Tooltip.Outer
-          variant="solid"
+              position="top"
-          color="primary"
+              visible={tooltipVisible}
-          size="large"
+              onVisibleChange={setTooltipVisible}>
-          label={_(msg`Continue to next step`)}
+              <Tooltip.Target>
-          onPress={saveInterests}>
+                <Pressable
-          <ButtonText>
+                  accessibilityRole="button"
-            <Trans>Continue</Trans>
+                  accessibilityLabel={l`Choose an interest`}
-          </ButtonText>
+                  accessibilityHint={l`Choose at least one interest to continue`}
-          {saving && <ButtonIcon icon={Loader} />}
+                  onPress={showMissingInterestTooltip}>
-        </Button>
+                  <View
+                    pointerEvents="none"
+                    accessibilityElementsHidden
+                    importantForAccessibility="no-hide-descendants">
+                    {continueButton}
+                  </View>
+                </Pressable>
+              </Tooltip.Target>
+              <Tooltip.BubbleText label={l`Choose at least one interest.`}>
+                <Trans>Choose at least one interest.</Trans>
+              </Tooltip.BubbleText>
+            </Tooltip.Outer>
+          ) : (
+            continueButton
+          )}
+        </View>
       </OnboardingControls.Portal>
     </View>
   )