From 52382be16858490c71205db5e7a33ed93eeeda95 Mon Sep 17 00:00:00 2001 From: vineyardbovines Date: Thu, 25 Jun 2026 16:02:54 -0400 Subject: [PATCH] test(bskyweb): fail loudly on golden JSON unmarshal errors --- bskyweb/cmd/bskyweb/passdata_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bskyweb/cmd/bskyweb/passdata_test.go b/bskyweb/cmd/bskyweb/passdata_test.go index 519de1f1c5..f9771ccd0f 100644 --- a/bskyweb/cmd/bskyweb/passdata_test.go +++ b/bskyweb/cmd/bskyweb/passdata_test.go @@ -53,8 +53,12 @@ func TestBuildPassJSON_Golden(t *testing.T) { t.Fatalf("read golden: %v", err) } var gotMap, wantMap map[string]any - _ = json.Unmarshal(got, &gotMap) - _ = json.Unmarshal(want, &wantMap) + if err := json.Unmarshal(got, &gotMap); err != nil { + t.Fatalf("unmarshal got: %v", err) + } + if err := json.Unmarshal(want, &wantMap); err != nil { + t.Fatalf("unmarshal want: %v", err) + } if !mapsEqual(gotMap, wantMap) { t.Errorf("pass.json drift; rerun with UPDATE_GOLDEN=1 to update.\n--- got ---\n%s\n--- want ---\n%s", got, want) }