From 4b9fa8e82daaa085980c9f2e3186d1f55744202e Mon Sep 17 00:00:00 2001 From: vineyardbovines Date: Wed, 10 Jun 2026 11:34:15 -0400 Subject: [PATCH] address review feedback: copy clarity, en dashes, reuse existing strings --- .../nuxs/InviteFriendsAnnouncement.tsx | 5 ++-- .../InviteFriendsDialogInner.tsx | 23 ++++++++++++------- .../components/ActionButtons.tsx | 2 +- 3 files changed, 19 insertions(+), 11 deletions(-) diff --git a/src/components/dialogs/nuxs/InviteFriendsAnnouncement.tsx b/src/components/dialogs/nuxs/InviteFriendsAnnouncement.tsx index 21cf92a5a1..48e4c05965 100644 --- a/src/components/dialogs/nuxs/InviteFriendsAnnouncement.tsx +++ b/src/components/dialogs/nuxs/InviteFriendsAnnouncement.tsx @@ -152,8 +152,9 @@ function Announcement({ {maxWidth: 340}, ]}> - You can now invite friends with a link or QR code. Share it - anywhere or let them scan to join you on Bluesky. + You can now invite friends with a link or QR code. Share the + link anywhere, or let them scan the code to join you on + Bluesky. diff --git a/src/features/inviteFriends/InviteFriendsDialogInner.tsx b/src/features/inviteFriends/InviteFriendsDialogInner.tsx index 7804e17607..7d2641a775 100644 --- a/src/features/inviteFriends/InviteFriendsDialogInner.tsx +++ b/src/features/inviteFriends/InviteFriendsDialogInner.tsx @@ -57,7 +57,7 @@ export function InviteFriendsDialogInner({ const onShare = async () => { if (!canonicalShareUrl) { - Toast.show(l`Could not share - please try again`, {type: 'error'}) + Toast.show(l`Could not share – please try again`, {type: 'error'}) return } ax.metric('invite:action:share', {}) @@ -71,7 +71,7 @@ export function InviteFriendsDialogInner({ const onDownload = async () => { if (!IS_NATIVE) return if (!canonicalShareUrl) { - Toast.show(l`Could not download - please try again`, {type: 'error'}) + Toast.show(l`Could not download – please try again`, {type: 'error'}) return } const uri = await captureRef.current?.capture?.() @@ -85,7 +85,7 @@ export function InviteFriendsDialogInner({ const permission = await requestPermissionsAsync(true) if (!permission.granted) { Toast.show( - l`You must grant access to your photo library to save the QR code`, + l`You must grant access to your photo library to save a QR code`, {type: 'error'}, ) return @@ -94,10 +94,12 @@ export function InviteFriendsDialogInner({ try { await createAssetAsync(`file://${uri}`) ax.metric('invite:action:download', {}) - Toast.show(l`QR code saved to your camera roll`) + Toast.show(l`QR code saved to your camera roll!`) } catch (err) { logger.error('InviteFriendsDialog: download failed', {safeMessage: err}) - Toast.show(l`Could not save QR code`, {type: 'error'}) + Toast.show(l`An error occurred while saving the QR code!`, { + type: 'error', + }) } } @@ -112,7 +114,7 @@ export function InviteFriendsDialogInner({ const onCopy = async () => { if (!canonicalShareUrl) { - Toast.show(l`Could not copy - please try again`, {type: 'error'}) + Toast.show(l`Could not copy – please try again`, {type: 'error'}) return } try { @@ -121,7 +123,7 @@ export function InviteFriendsDialogInner({ Toast.show(l`Invite link copied`) } catch (err) { logger.error('InviteFriendsDialog: copy failed', {safeMessage: err}) - Toast.show(l`Could not copy link`, {type: 'error'}) + Toast.show(l`Failed to copy link`, {type: 'error'}) } } @@ -205,7 +207,12 @@ export function InviteFriendsDialogInner({ ]}> - {l`Invite link`} + {l({ + message: 'Invite link', + context: 'profile invite', + comment: + 'Link that invites someone to follow your profile, distinct from a group chat invite link', + })} diff --git a/src/features/inviteFriends/components/ActionButtons.tsx b/src/features/inviteFriends/components/ActionButtons.tsx index a1ffef7989..b96af58139 100644 --- a/src/features/inviteFriends/components/ActionButtons.tsx +++ b/src/features/inviteFriends/components/ActionButtons.tsx @@ -36,7 +36,7 @@ export function ActionButtons({ {l`Download`}