From 46076c4afb8050325912afe825d27c9efd1e736c Mon Sep 17 00:00:00 2001
From: Eric Bailey <git@esb.lol>
Date: Tue, 13 Feb 2024 18:00:41 -0600
Subject: [PATCH] Some validation, fixes

---
 .../PreferenceRow.tsx                         | 10 ++++++----
 src/state/queries/modservice.ts               | 19 ++++++++++++++++++-
 2 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/src/screens/ProfileModerationService/PreferenceRow.tsx b/src/screens/ProfileModerationService/PreferenceRow.tsx
index 16f3d83f15..77b37931a6 100644
--- a/src/screens/ProfileModerationService/PreferenceRow.tsx
+++ b/src/screens/ProfileModerationService/PreferenceRow.tsx
@@ -1,8 +1,8 @@
 import React from 'react'
 import {View} from 'react-native'
 import {useLingui} from '@lingui/react'
-import {msg} from '@lingui/macro'
-import {LABEL_GROUPS, AppBskyModerationDefs} from '@atproto/api'
+// import {msg} from '@lingui/macro'
+import {LABEL_GROUPS} from '@atproto/api'
 // TODO
 import {ModPrefItem} from '@atproto/api/dist/client/types/app/bsky/actor/defs'
 
@@ -24,7 +24,7 @@ export function PreferenceRow({
   const {_} = useLingui()
   const labelGroupStrings = useLabelGroupStrings()
   const groupInfoStrings = labelGroupStrings[labelGroup]
-  const {mutateAsync, variables} = useModServiceLabelGroupEnableMutation()
+  const {mutateAsync, variables, reset} = useModServiceLabelGroupEnableMutation()
   const enabled =
     variables?.enabled ??
     !modservicePreferences?.disabledLabelGroups?.includes(labelGroup)
@@ -37,10 +37,12 @@ export function PreferenceRow({
         group: labelGroup,
         enabled: !enabled,
       })
+      reset() // Important: clears query `variables`
     } catch (e: any) {
+      // TODO
       console.error(e)
     }
-  }, [mutateAsync, enabled])
+  }, [mutateAsync, enabled, modservicePreferences, labelGroup, reset])
 
   return (
     <View
diff --git a/src/state/queries/modservice.ts b/src/state/queries/modservice.ts
index e7cc06b7e7..ea5cfc17a9 100644
--- a/src/state/queries/modservice.ts
+++ b/src/state/queries/modservice.ts
@@ -1,3 +1,4 @@
+import {z} from 'zod'
 import {useQuery, useMutation, useQueryClient} from '@tanstack/react-query'
 
 import {getAgent} from '#/state/session'
@@ -20,6 +21,12 @@ export function useModServiceSubscriptionMutation() {
 
   return useMutation({
     async mutationFn({did, subscribe}: {did: string; subscribe: boolean}) {
+      // TODO
+      z.object({
+        did: z.string(),
+        subscribe: z.boolean(),
+      }).parse({did, subscribe})
+
       if (subscribe) {
         await getAgent().addModService(did)
       } else {
@@ -39,6 +46,11 @@ export function useModServiceEnableMutation() {
 
   return useMutation({
     async mutationFn({did, enabled}: {did: string; enabled: boolean}) {
+      // TODO
+      z.object({
+        did: z.string(),
+        enabled: z.boolean(),
+      }).parse({did, enabled})
       await getAgent().setModServiceEnabled(did, enabled)
     },
     onSuccess() {
@@ -54,7 +66,12 @@ export function useModServiceLabelGroupEnableMutation() {
 
   return useMutation({
     async mutationFn({did, group, enabled}: {did: string; group: string, enabled: boolean}) {
-      console.log('useModServiceLabelGroupEnableMutation', did, group, enabled)
+      // TODO
+      z.object({
+        did: z.string(),
+        group: z.string(),
+        enabled: z.boolean(),
+      }).parse({did, group, enabled})
       await getAgent().setModServiceLabelGroupEnabled(did, group, enabled)
     },
     onSuccess() {