Don't hide recommended (#7166)

* Don't hide recommended

* Rm unused
This commit is contained in:
dan
2024-12-18 23:31:18 +00:00
committed by GitHub
parent 65eccc79aa
commit 45c6308607
2 changed files with 3 additions and 32 deletions
+1 -5
View File
@@ -239,10 +239,6 @@ export type LogEvents = {
'trendingTopics:show': {} 'trendingTopics:show': {}
'trendingTopics:hide': { 'trendingTopics:hide': {
context: context: 'sidebar' | 'interstitial' | 'explore:trending'
| 'sidebar'
| 'interstitial'
| 'explore:trending'
| 'explore:recommendations'
} }
} }
@@ -1,14 +1,7 @@
import React from 'react'
import {View} from 'react-native' import {View} from 'react-native'
import {msg, Trans} from '@lingui/macro' import {Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react'
import {logEvent} from '#/lib/statsig/statsig'
import {isWeb} from '#/platform/detection' import {isWeb} from '#/platform/detection'
import {
useTrendingSettings,
useTrendingSettingsApi,
} from '#/state/preferences/trending'
import { import {
DEFAULT_LIMIT as RECOMMENDATIONS_COUNT, DEFAULT_LIMIT as RECOMMENDATIONS_COUNT,
useTrendingTopics, useTrendingTopics,
@@ -16,7 +9,6 @@ import {
import {useTrendingConfig} from '#/state/trending-config' import {useTrendingConfig} from '#/state/trending-config'
import {atoms as a, useGutters, useTheme} from '#/alf' import {atoms as a, useGutters, useTheme} from '#/alf'
import {Hashtag_Stroke2_Corner0_Rounded} from '#/components/icons/Hashtag' import {Hashtag_Stroke2_Corner0_Rounded} from '#/components/icons/Hashtag'
import * as Prompt from '#/components/Prompt'
import { import {
TrendingTopic, TrendingTopic,
TrendingTopicLink, TrendingTopicLink,
@@ -26,23 +18,14 @@ import {Text} from '#/components/Typography'
export function ExploreRecommendations() { export function ExploreRecommendations() {
const {enabled} = useTrendingConfig() const {enabled} = useTrendingConfig()
const {trendingDisabled} = useTrendingSettings() return enabled ? <Inner /> : null
return enabled && !trendingDisabled ? <Inner /> : null
} }
function Inner() { function Inner() {
const t = useTheme() const t = useTheme()
const {_} = useLingui()
const gutters = useGutters([0, 'compact']) const gutters = useGutters([0, 'compact'])
const {data: trending, error, isLoading} = useTrendingTopics() const {data: trending, error, isLoading} = useTrendingTopics()
const noRecs = !isLoading && !error && !trending?.suggested?.length const noRecs = !isLoading && !error && !trending?.suggested?.length
const {setTrendingDisabled} = useTrendingSettingsApi()
const trendingPrompt = Prompt.usePromptControl()
const onConfirmHide = React.useCallback(() => {
logEvent('trendingTopics:hide', {context: 'explore:recommendations'})
setTrendingDisabled(true)
}, [setTrendingDisabled])
return error || noRecs ? null : ( return error || noRecs ? null : (
<> <>
@@ -106,14 +89,6 @@ function Inner() {
)} )}
</View> </View>
</View> </View>
<Prompt.Basic
control={trendingPrompt}
title={_(msg`Hide trending topics?`)}
description={_(msg`You can update this later from your settings.`)}
confirmButtonCta={_(msg`Hide`)}
onConfirm={onConfirmHide}
/>
</> </>
) )
} }