From 450611ab2ca8caa5b158388be38e79bca867f0ef Mon Sep 17 00:00:00 2001 From: Hailey Date: Thu, 11 Sep 2025 00:23:00 -0700 Subject: [PATCH] cleanup --- bskylink/src/cache/safelinkClient.ts | 2 -- bskylink/src/metrics.ts | 2 +- bskylink/src/routes/redirect.ts | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/bskylink/src/cache/safelinkClient.ts b/bskylink/src/cache/safelinkClient.ts index 720642db32..a3baa13d77 100644 --- a/bskylink/src/cache/safelinkClient.ts +++ b/bskylink/src/cache/safelinkClient.ts @@ -104,7 +104,6 @@ export class SafelinkClient { this.urlCache.set(url, maybeUrlRule) addMetrics('ok', false) - return maybeUrlRule } catch (e) { this.urlCache.set(url, 'ok') @@ -115,7 +114,6 @@ export class SafelinkClient { this.domainCache.set(domain, maybeDomainRule) addMetrics('ok', false) - return maybeDomainRule } catch (e) { this.domainCache.set(domain, 'ok') diff --git a/bskylink/src/metrics.ts b/bskylink/src/metrics.ts index 7ffc58364d..2310f1359f 100644 --- a/bskylink/src/metrics.ts +++ b/bskylink/src/metrics.ts @@ -74,6 +74,6 @@ export class Metrics { async start(port: number) { const server = this.app.listen(port) - await once(server, 'listening') + await once(server, 'metrics server listening') } } diff --git a/bskylink/src/routes/redirect.ts b/bskylink/src/routes/redirect.ts index d4ce26ff70..43de79d530 100644 --- a/bskylink/src/routes/redirect.ts +++ b/bskylink/src/routes/redirect.ts @@ -98,7 +98,6 @@ export default function (ctx: AppContext, app: Express) { } addMetrics(ruleStr, 302) - return res.end(html) }), )