Add new chat notification preferences (#10972)

src/state/queries/notifications/settings.ts

@@ -1,4 +1,7 @@
-import {type AppBskyNotificationDefs} from '@atproto/api'
+import {
+  type AppBskyNotificationDefs,
+  type ChatBskyNotificationDefs,
+} from '@atproto/api'
 import {t} from '@lingui/core/macro'
 import {
   type QueryClient,
@@ -7,12 +10,59 @@ import {
   useQueryClient,
 } from '@tanstack/react-query'
 
+import {DM_SERVICE_HEADERS} from '#/lib/constants'
 import {logger} from '#/logger'
 import {useAgent} from '#/state/session'
 import * as Toast from '#/components/Toast'
 
 const RQKEY_ROOT = 'notification-settings'
-const RQKEY = [RQKEY_ROOT]
+const RQKEY_APP = [RQKEY_ROOT, 'app']
+const RQKEY_CHAT = [RQKEY_ROOT, 'chat']
+
+// App notification preferences live on the appview. Chat preferences live on a
+// separate chat service proxy that can be up or down independently, so they are
+// fetched and cached separately. This combined type names every preference for
+// the generic settings dialog, but it is never the shape of a query response.
+export type NotificationSettingsPreferences = Omit<
+  AppBskyNotificationDefs.Preferences,
+  'chat'
+> &
+  Partial<Pick<ChatBskyNotificationDefs.Preferences, 'chat' | 'chatRequest'>>
+
+export type AppNotificationSettingsPreferences = Omit<
+  AppBskyNotificationDefs.Preferences,
+  'chat'
+>
+
+export type ChatNotificationSettingsPreferences = Pick<
+  ChatBskyNotificationDefs.Preferences,
+  'chat' | 'chatRequest'
+>
+
+export type NotificationSettingsPreferenceName = Exclude<
+  keyof NotificationSettingsPreferences,
+  '$type'
+>
+
+export type NotificationSettingsPreference =
+  | AppBskyNotificationDefs.Preference
+  | AppBskyNotificationDefs.FilterablePreference
+  | ChatBskyNotificationDefs.ChatPreference
+
+export function isChatPreferenceName(
+  name: NotificationSettingsPreferenceName,
+): name is 'chat' | 'chatRequest' {
+  return name === 'chat' || name === 'chatRequest'
+}
+
+type NotificationSettingsUpdate = Partial<NotificationSettingsPreferences>
+
+type AppNotificationSettingsUpdate = Partial<
+  Omit<AppBskyNotificationDefs.Preferences, '$type' | 'chat'>
+>
+
+type ChatNotificationSettingsUpdate =
+  Partial<ChatNotificationSettingsPreferences>
 
 export function useNotificationSettingsQuery({
   enabled,
@@ -20,10 +70,27 @@ export function useNotificationSettingsQuery({
   const agent = useAgent()
 
   return useQuery({
-    queryKey: RQKEY,
-    queryFn: async () => {
-      const response = await agent.app.bsky.notification.getPreferences()
-      return response.data.preferences
+    queryKey: RQKEY_APP,
+    queryFn: async (): Promise<AppNotificationSettingsPreferences> => {
+      const res = await agent.app.bsky.notification.getPreferences()
+      return appPreferencesWithoutChat(res.data.preferences)
+    },
+    enabled,
+  })
+}
+
+export function useChatNotificationSettingsQuery({
+  enabled,
+}: {enabled?: boolean} = {}) {
+  const agent = useAgent()
+
+  return useQuery({
+    queryKey: RQKEY_CHAT,
+    queryFn: async (): Promise<ChatNotificationSettingsPreferences> => {
+      const res = await agent.chat.bsky.notification.getPreferences(undefined, {
+        headers: DM_SERVICE_HEADERS,
+      })
+      return chatPreferencesForSettings(res.data.preferences)
     },
     enabled,
   })
@@ -33,19 +100,27 @@ export function useNotificationSettingsUpdateMutation() {
   const queryClient = useQueryClient()
 
   return useMutation({
-    mutationFn: async (
-      update: Partial<AppBskyNotificationDefs.Preferences>,
-    ) => {
-      const response =
-        await agent.app.bsky.notification.putPreferencesV2(update)
-      return response.data.preferences
+    mutationFn: async (update: NotificationSettingsUpdate) => {
+      const {appUpdate, chatUpdate} = splitNotificationSettingsUpdate(update)
+      await Promise.all([
+        hasUpdates(appUpdate)
+          ? agent.app.bsky.notification.putPreferencesV2(appUpdate)
+          : undefined,
+        hasUpdates(chatUpdate)
+          ? agent.chat.bsky.notification.putPreferences(chatUpdate, {
+              headers: DM_SERVICE_HEADERS,
+              encoding: 'application/json',
+            })
+          : undefined,
+      ])
     },
     onMutate: update => {
       optimisticUpdateNotificationSettings(queryClient, update)
     },
     onError: e => {
       logger.error('Could not update notification settings', {message: e})
-      void queryClient.invalidateQueries({queryKey: RQKEY})
+      void queryClient.invalidateQueries({queryKey: RQKEY_APP})
+      void queryClient.invalidateQueries({queryKey: RQKEY_CHAT})
       Toast.show(t`Could not update notification settings`, {
         type: 'error',
       })
@@ -55,13 +130,62 @@ export function useNotificationSettingsUpdateMutation() {
 
 function optimisticUpdateNotificationSettings(
   queryClient: QueryClient,
-  update: Partial<AppBskyNotificationDefs.Preferences>,
+  update: NotificationSettingsUpdate,
 ) {
-  queryClient.setQueryData(
-    RQKEY,
-    (old?: AppBskyNotificationDefs.Preferences) => {
-      if (!old) return old
-      return {...old, ...update}
-    },
-  )
+  const {appUpdate, chatUpdate} = splitNotificationSettingsUpdate(update)
+
+  if (hasUpdates(appUpdate)) {
+    queryClient.setQueryData(
+      RQKEY_APP,
+      (old?: AppNotificationSettingsPreferences) => {
+        if (!old) return old
+        return {...old, ...appUpdate}
+      },
+    )
+  }
+
+  if (hasUpdates(chatUpdate)) {
+    queryClient.setQueryData(
+      RQKEY_CHAT,
+      (old?: ChatNotificationSettingsPreferences) => {
+        if (!old) return old
+        return {...old, ...chatUpdate}
+      },
+    )
+  }
+}
+
+function appPreferencesWithoutChat(
+  preferences: AppBskyNotificationDefs.Preferences,
+): Omit<AppBskyNotificationDefs.Preferences, 'chat'> {
+  const {chat: _ignoredChat, ...appPreferences} = preferences
+  return appPreferences
+}
+
+function chatPreferencesForSettings(
+  preferences: ChatBskyNotificationDefs.Preferences,
+): Pick<ChatBskyNotificationDefs.Preferences, 'chat' | 'chatRequest'> {
+  return {
+    chat: preferences.chat,
+    chatRequest: preferences.chatRequest,
+  }
+}
+
+function splitNotificationSettingsUpdate(update: NotificationSettingsUpdate): {
+  appUpdate: AppNotificationSettingsUpdate
+  chatUpdate: ChatNotificationSettingsUpdate
+} {
+  const {chat, chatRequest, $type: _type, ...appUpdate} = update
+
+  return {
+    appUpdate: appUpdate,
+    chatUpdate: {
+      ...(chat !== undefined ? {chat} : {}),
+      ...(chatRequest !== undefined ? {chatRequest} : {}),
+    },
+  }
+}
+
+function hasUpdates(update: object) {
+  return Object.keys(update).length > 0
 }