More e2e test fixes (#5982)

* fix feed reorder test

* fix feed reorder test pt 2

* fix edit profile test

* fix mod list test

* fix fab

* add assert

* one more assertVisible

* fix search test

* tap now now if it shows up

__e2e__/flows/composer-self-label.yml

@@ -10,6 +10,8 @@ appId: xyz.blueskyweb.app
     id: "e2eSignInAlice"
 
 # Post an image with the porn label
+- assertVisible:
+      id: "composeFAB"
 - tapOn:
     id: "composeFAB"
 - inputText: "Post with an image"

__e2e__/flows/composer.yml

@@ -8,6 +8,8 @@ appId: xyz.blueskyweb.app
     file: ../setupApp.yml
 - tapOn:
     id: "e2eSignInAlice"
+- assertVisible:
+      id: "composeFAB"
 - tapOn:
     id: "composeFAB"
 - inputText: "Post text only"

__e2e__/flows/create-account.yml

@@ -29,6 +29,7 @@ appId: xyz.blueskyweb.app
 - pressKey: Enter
 - tapOn:
     id: "nextBtn"
+- tapOn: "Not now"
 - tapOn:
      id: "handleInput"
 - inputText: "e2e-test"

__e2e__/flows/curate-lists.yml

@@ -23,7 +23,6 @@ appId: xyz.blueskyweb.app
     id: "editDescriptionInput"
 - inputText: "They good"
 - tapOn: "Save"
-- tapOn: "Save"
 - assertNotVisible:
     id: "createOrEditListModal"
 - tapOn: "About"
@@ -46,7 +45,6 @@ appId: xyz.blueskyweb.app
 - eraseText
 - inputText: "They bad"
 - tapOn: "Save"
-- tapOn: "Save"
 - assertNotVisible:
     id: "createOrEditListModal"
 - assertVisible: Bad Ppl
@@ -62,7 +60,6 @@ appId: xyz.blueskyweb.app
     id: "editDescriptionInput"
 - eraseText
 - tapOn: "Save"
-- tapOn: "Save"
 - assertNotVisible:
     id: "createOrEditListModal"
 - assertNotVisible:
@@ -90,7 +87,6 @@ appId: xyz.blueskyweb.app
     id: "editDescriptionInput"
 - inputText: "They good"
 - tapOn: "Save"
-- tapOn: "Save"
 - assertNotVisible:
     id: "createOrEditListModal"
 - tapOn: "About"

__e2e__/flows/feed-reorder.yml

@@ -40,9 +40,10 @@ appId: xyz.blueskyweb.app
     id: "editFeedsBtn"
 - tapOn:
     label: "Tap on down arrow"
-    point: "79%,23%"
+    id: "feed-timeline-moveDown"
 - tapOn:
-    id: "viewHeaderDrawerBtn"
+      label: "Save button"
+      id: "saveChangesBtn"
 - tapOn:
     id: "viewHeaderDrawerBtn"
 - assertVisible:
@@ -61,9 +62,10 @@ appId: xyz.blueskyweb.app
     id: "editFeedsBtn"
 - tapOn:
     label: "Tap on down arrow"
-    point: "79%,23%"
+    id: "feed-feed-moveDown"
 - tapOn:
-    id: "viewHeaderDrawerBtn"
+    label: "Save button"
+    id: "saveChangesBtn"
 - tapOn:
     id: "viewHeaderDrawerBtn"
 - assertVisible:
@@ -82,9 +84,10 @@ appId: xyz.blueskyweb.app
     id: "editFeedsBtn"
 - tapOn:
     label: "Tap on unpin"
-    point: "91%,23%"
+    id: "feed-timeline-togglePin"
 - tapOn:
-    id: "viewHeaderDrawerBtn"
+      label: "Save button"
+      id: "saveChangesBtn"
 - tapOn:
     id: "viewHeaderDrawerBtn"
 - assertVisible:

__e2e__/flows/login.yml

@@ -23,4 +23,5 @@ appId: xyz.blueskyweb.app
     id: "loginPasswordInput"
 - inputText: "hunter2"
 - pressKey: Enter
+- tapOn: "Not now"
 - assertVisible: "Following"

__e2e__/flows/mod-lists.yml

@@ -22,22 +22,23 @@ appId: xyz.blueskyweb.app
     id: "editDescriptionInput"
 - inputText: "Shhh"
 - tapOn: "Save"
-- tapOn: "Save"
 
 # view modlist
 - assertVisible: "Muted Users"
 - assertVisible: "Shhh"
 
-# toggle mute subscription
 - tapOn:
-    point: "70%,9%"
+    label: "Dropdown"
+    point: "71%,9%"
+
 - tapOn: "Mute accounts"
 - tapOn: "Mute list"
 - tapOn: "Unmute"
 
-# toggle block subscription
 - tapOn:
-    point: "70%,9%"
+      label: "Dropdown"
+      point: "71%,9%"
+
 - tapOn: "Block accounts"
 - tapOn: "Block list"
 - tapOn: "Unblock"

__e2e__/flows/search-screen.yml

@@ -12,6 +12,7 @@ appId: xyz.blueskyweb.app
 # Navigate to another user profile via autocomplete
 - tapOn:
     id: "bottomBarSearchBtn"
+- assertVisible: "Search"
 - tapOn: "Search"
 - inputText: "b"
 - tapOn:

__e2e__/flows/shared-prefs.yml

@@ -8,6 +8,8 @@ appId: xyz.blueskyweb.app
     file: ../setupApp.yml
 - tapOn:
     id: "e2eSignInAlice"
+- assertVisible:
+      id: "storybookBtn"
 - tapOn:
     id: "storybookBtn"
 - tapOn:

__e2e__/flows/thread-muting.yml

@@ -7,10 +7,11 @@ appId: xyz.blueskyweb.app
 - runFlow:
     file: ../setupApp.yml
 
-
 # Login, create a thread, and log out
 - tapOn:
     id: "e2eSignInAlice"
+- assertVisible:
+    id: "composeFAB"
 - tapOn:
     id: "composeFAB"
 - inputText: "Test thread"

src/screens/Profile/Header/EditProfileDialog.tsx

@@ -67,7 +67,8 @@ export function EditProfileDialog({
       nativeOptions={{
         preventDismiss: dirty,
         minHeight: SCREEN_HEIGHT,
-      }}>
+      }}
+      testID="editProfileModal">
       <DialogInner
         profile={profile}
         onUpdate={onUpdate}
@@ -221,7 +222,8 @@ function DialogInner({
         size="small"
         color="primary"
         variant="ghost"
-        style={[a.rounded_full]}>
+        style={[a.rounded_full]}
+        testID="editProfileCancelBtn">
         <ButtonText style={[a.text_md]}>
           <Trans>Cancel</Trans>
         </ButtonText>
@@ -244,7 +246,8 @@ function DialogInner({
         size="small"
         color="primary"
         variant="ghost"
-        style={[a.rounded_full]}>
+        style={[a.rounded_full]}
+        testID="editProfileSaveBtn">
         <ButtonText style={[a.text_md, !dirty && t.atoms.text_contrast_low]}>
           <Trans>Save</Trans>
         </ButtonText>
@@ -316,6 +319,7 @@ function DialogInner({
               onChangeText={setDisplayName}
               label={_(msg`Display name`)}
               placeholder={_(msg`e.g. Alice Lastname`)}
+              testID="editProfileDisplayNameInput"
             />
           </TextField.Root>
           {displayNameTooLong && (
@@ -346,6 +350,7 @@ function DialogInner({
               multiline
               label={_(msg`Display name`)}
               placeholder={_(msg`Tell us a bit about yourself`)}
+              testID="editProfileDescriptionInput"
             />
           </TextField.Root>
           {descriptionTooLong && (

src/view/screens/SavedFeeds.tsx

@@ -97,7 +97,8 @@ function SavedFeedsInner({
         onPress={onSaveChanges}
         label={_(msg`Save changes`)}
         disabled={isOverwritePending || !hasUnsavedChanges}
-        style={[isDesktop && a.mt_sm]}>
+        style={[isDesktop && a.mt_sm]}
+        testID="saveChangesBtn">
         <ButtonText style={[isDesktop && a.text_md]}>
           {isDesktop ? <Trans>Save changes</Trans> : <Trans>Save</Trans>}
         </ButtonText>
@@ -315,7 +316,8 @@ function ListItem({
               borderRadius: 4,
               marginRight: 8,
               opacity: state.hovered || state.pressed ? 0.5 : 1,
-            })}>
+            })}
+            testID={`feed-${feed.type}-moveUp`}>
             <FontAwesomeIcon
               icon="arrow-up"
               size={14}
@@ -333,7 +335,8 @@ function ListItem({
               borderRadius: 4,
               marginRight: 8,
               opacity: state.hovered || state.pressed ? 0.5 : 1,
-            })}>
+            })}
+            testID={`feed-${feed.type}-moveDown`}>
             <FontAwesomeIcon
               icon="arrow-down"
               size={14}
@@ -374,7 +377,8 @@ function ListItem({
             paddingVertical: 10,
             borderRadius: 4,
             opacity: state.hovered || state.focused ? 0.5 : 1,
-          })}>
+          })}
+          testID={`feed-${feed.type}-togglePin`}>
           <FontAwesomeIcon
             icon="thumb-tack"
             size={14}