From 30789bd49d18e6dbc9ccfd05dea99107b8316f36 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 19 Jan 2025 18:10:24 +0000 Subject: [PATCH] Refactor for clarity --- src/view/com/posts/PostFeed.tsx | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/view/com/posts/PostFeed.tsx b/src/view/com/posts/PostFeed.tsx index f74603e251..c5b587bf76 100644 --- a/src/view/com/posts/PostFeed.tsx +++ b/src/view/com/posts/PostFeed.tsx @@ -350,25 +350,28 @@ let PostFeed = ({ let sliceIndex = -1 if (isVideoFeedAndIsEnabled) { - const rows: { + const videos: { item: FeedPostSliceItem feedContext: string | undefined - }[][] = [] - let slices: {slice: FeedPostSlice; root: FeedPostSliceItem}[] = [] + }[] = [] for (const page of data.pages) { for (const slice of page.slices) { - const root = slice.items.at(0) - if (root && AppBskyEmbedVideo.isView(root.post.embed)) { - slices.push({slice, root}) + const item = slice.items.at(0) + if (item && AppBskyEmbedVideo.isView(item.post.embed)) { + videos.push({item, feedContext: slice.feedContext}) } } } - for (let i = 0; i < slices.length; i++) { - const slice = slices[i] - const root = slice.root + const rows: { + item: FeedPostSliceItem + feedContext: string | undefined + }[][] = [] + for (let i = 0; i < videos.length; i++) { + const video = videos[i] + const item = video.item const cols = gtMobile ? 3 : 2 - const rowItem = {item: root, feedContext: slice.slice.feedContext} + const rowItem = {item, feedContext: video.feedContext} if (i % cols === 0) { rows.push([rowItem]) } else {