From 1e8d7c651734ff280cf57581ef786a357c752bf7 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 5 Oct 2023 21:35:00 +0100 Subject: [PATCH] Add more TODO comments --- .../ImageViewing/components/ImageItem/ImageItem.ios.tsx | 3 +++ src/view/com/lightbox/ImageViewing/hooks/usePanResponder.ts | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx index aa234510a9..f6fb759efc 100644 --- a/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx +++ b/src/view/com/lightbox/ImageViewing/components/ImageItem/ImageItem.ios.tsx @@ -55,6 +55,9 @@ const ImageItem = ({imageSrc, onZoom, onRequestClose}: Props) => { ) const [translate, scale] = getImageTransform(imageDimensions, SCREEN) + + // TODO: It's not valid to reinitialize Animated values during render. + // This is a bug. const scrollValueY = new Animated.Value(0) const scaleValue = new Animated.Value(scale || 1) const translateValue = new Animated.ValueXY(translate) diff --git a/src/view/com/lightbox/ImageViewing/hooks/usePanResponder.ts b/src/view/com/lightbox/ImageViewing/hooks/usePanResponder.ts index f1027e8fe3..4426ba89ed 100644 --- a/src/view/com/lightbox/ImageViewing/hooks/usePanResponder.ts +++ b/src/view/com/lightbox/ImageViewing/hooks/usePanResponder.ts @@ -56,6 +56,8 @@ const usePanResponder = ({ let isDoubleTapPerformed = false let lastTapTS: number | null = null + // TODO: It's not valid to reinitialize Animated values during render. + // This is a bug. const scaleValue = new Animated.Value(initialScale) const translateValue = new Animated.ValueXY(initialTranslate)