From 1cc39c65f5e3f42094729a3f1c8f67eb97851f73 Mon Sep 17 00:00:00 2001 From: Zaven477 <77801431+Zaven477@users.noreply.github.com> Date: Fri, 26 Jun 2026 00:12:08 +0400 Subject: [PATCH] Fix video alt text (#10947) --- README.md | 69 +------------------ .../VideoEmbed/GifPresentationControls.tsx | 4 +- .../VideoEmbedInner/VideoEmbedInnerNative.tsx | 3 +- .../VideoEmbedInner/VideoEmbedInnerWeb.tsx | 4 ++ 4 files changed, 9 insertions(+), 71 deletions(-) diff --git a/README.md b/README.md index ae4511cc3b..90ea277dd9 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Bluesky Social App -Welcome friends! This is the codebase for the Bluesky Social app. +Welcome friends! This is the code from the original Bluesky Social app repository. Get the app itself: @@ -8,70 +8,3 @@ Get the app itself: - **iOS: [App Store](https://apps.apple.com/us/app/bluesky-social/id6444370199)** - **Android: [Play Store](https://play.google.com/store/apps/details?id=xyz.blueskyweb.app)** -## Development Resources - -This is a [React Native](https://reactnative.dev/) application, written in the TypeScript programming language. It builds on the `atproto` TypeScript packages (like [`@atproto/api`](https://www.npmjs.com/package/@atproto/api)), which are also open source, but in [a different git repository](https://github.com/bluesky-social/atproto). - -There is a small amount of Go language source code (in `./bskyweb/`), for a web service that returns the React Native Web application. - -The [Build Instructions](./docs/build.md) are a good place to get started with the app itself. - -The Authenticated Transfer Protocol ("AT Protocol" or "atproto") is a decentralized social media protocol. You don't *need* to understand AT Protocol to work with this application, but it can help. Learn more at: - -- [Overview and Guides](https://atproto.com/guides/overview) -- [GitHub Discussions](https://github.com/bluesky-social/atproto/discussions) 👈 Great place to ask questions -- [Protocol Specifications](https://atproto.com/specs/atp) -- [Blogpost on self-authenticating data structures](https://bsky.social/about/blog/3-6-2022-a-self-authenticating-social-protocol) - -The Bluesky Social application encompasses a set of schemas and APIs built in the overall AT Protocol framework. The namespace for these "Lexicons" is `app.bsky.*`. - -## Contributions - -> [!NOTE] -> While we do accept contributions, we prioritize high quality issues and pull requests. Adhering to the below guidelines will ensure a more timely review. - -**Rules:** - -- We may not respond to your issue or PR. -- We may close an issue or PR without much feedback. -- We may lock discussions or contributions if our attention is getting DDOSed. -- We're not going to provide support for build issues. - -**Guidelines:** - -- Check for existing issues before filing a new one please. -- Open an issue and give some time for discussion before submitting a PR. -- Stay away from PRs like... - - Changing "Post" to "Skeet." - - Refactoring the codebase, e.g., to replace React Query with Redux Toolkit or something. - - Adding entirely new features without prior discussion. - -Remember, we serve a wide community of users. Our day-to-day involves us constantly asking "which top priority is our top priority." If you submit well-written PRs that solve problems concisely, that's an awesome contribution. Otherwise, as much as we'd love to accept your ideas and contributions, we really don't have the bandwidth. That's what forking is for! - -## Forking guidelines - -You have our blessing 🪄✨ to fork this application! However, it's very important to be clear to users when you're giving them a fork. - -Please be sure to: - -- Change all branding in the repository and UI to clearly differentiate from Bluesky. -- Change any support links (feedback, email, terms of service, etc) to your own systems. -- Replace any analytics or error-collection systems with your own so we don't get super confused. - -## Security disclosures - -If you discover any security issues, please send an email to security@bsky.app. The email is automatically CC'd to the entire team and we'll respond promptly. - -## Are you a developer interested in building on atproto? - -Bluesky is an open social network built on the AT Protocol, a flexible technology that will never lock developers out of the ecosystems that they help build. With atproto, third-party integration can be as seamless as first-party through custom feeds, federated services, clients, and more. - -## License (MIT) - -See [./LICENSE](./LICENSE) for the full license. - -Bluesky Social PBC has committed to a software patent non-aggression pledge. For details see [the original announcement](https://bsky.social/about/blog/10-01-2025-patent-pledge). - -## P.S. - -We ❤️ you and all of the ways you support us. Thank you for making Bluesky a great place! diff --git a/src/components/Post/Embed/VideoEmbed/GifPresentationControls.tsx b/src/components/Post/Embed/VideoEmbed/GifPresentationControls.tsx index d59796ec69..2989421dbd 100644 --- a/src/components/Post/Embed/VideoEmbed/GifPresentationControls.tsx +++ b/src/components/Post/Embed/VideoEmbed/GifPresentationControls.tsx @@ -74,7 +74,7 @@ export function GifPresentationControls({ ) } -function AltBadge({text}: {text: string}) { +export function AltBadge({text}: {text: string}) { const control = Prompt.usePromptControl() const {_} = useLingui() @@ -131,7 +131,7 @@ const styles = StyleSheet.create({ paddingVertical: 3, position: 'absolute', right: 6, - bottom: 6, + top: 6, zIndex: 2, }, }) diff --git a/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerNative.tsx b/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerNative.tsx index 05e8b84581..1060d66d9b 100644 --- a/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerNative.tsx +++ b/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerNative.tsx @@ -16,7 +16,7 @@ import {SpeakerVolumeFull_Stroke2_Corner0_Rounded as UnmuteIcon} from '#/compone import {KeepAwake} from '#/components/KeepAwake' import {MediaInsetBorder} from '#/components/MediaInsetBorder' import {useVideoMuteState} from '#/components/Post/Embed/VideoEmbed/VideoVolumeContext' -import {GifPresentationControls} from '../GifPresentationControls' +import {AltBadge, GifPresentationControls} from '../GifPresentationControls' import {TimeIndicator} from './TimeIndicator' export function VideoEmbedInnerNative({ @@ -112,6 +112,7 @@ export function VideoEmbedInnerNative({ timeRemaining={timeRemaining} /> )} + {!isGif && embed.alt && } diff --git a/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerWeb.tsx b/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerWeb.tsx index d56c0b234d..3b0f028507 100644 --- a/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerWeb.tsx +++ b/src/components/Post/Embed/VideoEmbed/VideoEmbedInner/VideoEmbedInnerWeb.tsx @@ -7,6 +7,8 @@ import type * as HlsTypes from 'hls.js' import {useNonReactiveCallback} from '#/lib/hooks/useNonReactiveCallback' import {atoms as a} from '#/alf' +import {useFullscreen} from '#/components/hooks/useFullscreen' +import {AltBadge} from '../GifPresentationControls' import * as BandwidthEstimate from './bandwidth-estimate' import {Controls} from './web-controls/VideoControls' @@ -30,6 +32,7 @@ export function VideoEmbedInnerWeb({ const [hlsLoading, setHlsLoading] = useState(false) const figId = useId() const {_} = useLingui() + const [isFullscreen] = useFullscreen(containerRef) // send error up to error boundary const [error, setError] = useState(null) @@ -77,6 +80,7 @@ export function VideoEmbedInnerWeb({ )} + {!isFullscreen && embed.alt && }