Remove BaseLink component (#5682)

* Remove BaseLink component

* Fix StarterPackCard Link component

* Rm flex_1 causing overflow

* Make newskie usage full width

src/components/Link.tsx

@@ -1,10 +1,5 @@
 import React from 'react'
-import {
+import {GestureResponderEvent} from 'react-native'
-  GestureResponderEvent,
-  Pressable,
-  StyleProp,
-  ViewStyle,
-} from 'react-native'
 import {sanitizeUrl} from '@braintree/sanitize-url'
 import {StackActions, useLinkProps} from '@react-navigation/native'
 
@@ -348,48 +343,6 @@ export function createStaticClick(
   }
 }
 
-/**
- * A Pressable that uses useLink to handle navigation. It is unstyled, so can be used in cases where the Button styles
- * in Link are not desired.
- * @param displayText
- * @param style
- * @param children
- * @param rest
- * @constructor
- */
-export function BaseLink({
-  displayText,
-  onPress: onPressOuter,
-  style,
-  children,
-  ...rest
-}: {
-  style?: StyleProp<ViewStyle>
-  children: React.ReactNode
-  to: string
-  action: 'push' | 'replace' | 'navigate'
-  onPress?: () => false | void
-  shareOnLongPress?: boolean
-  label: string
-  displayText?: string
-}) {
-  const {onPress, ...btnProps} = useLink({
-    displayText: displayText ?? rest.to,
-    ...rest,
-  })
-  return (
-    <Pressable
-      style={style}
-      onPress={e => {
-        onPressOuter?.()
-        onPress(e)
-      }}
-      {...btnProps}>
-      {children}
-    </Pressable>
-  )
-}
-
 export function WebOnlyInlineLinkText({
   children,
   to,

src/components/NewskieDialog.tsx

@@ -127,7 +127,7 @@ export function NewskieDialog({
                 }}>
                 <View
                   style={[
-                    a.flex_1,
+                    a.w_full,
                     a.mt_sm,
                     a.p_lg,
                     a.border,

src/components/StarterPack/StarterPackCard.tsx

@@ -13,7 +13,7 @@ import {precacheStarterPack} from '#/state/queries/starter-packs'
 import {useSession} from '#/state/session'
 import {atoms as a, useTheme} from '#/alf'
 import {StarterPack} from '#/components/icons/StarterPack'
-import {BaseLink} from '#/components/Link'
+import {Link as BaseLink, LinkProps as BaseLinkProps} from '#/components/Link'
 import {Text} from '#/components/Typography'
 
 export function Default({
@@ -62,7 +62,7 @@ export function Card({
   }
 
   return (
-    <View style={[a.flex_1, a.gap_md]}>
+    <View style={[a.w_full, a.gap_md]}>
       <View style={[a.flex_row, a.gap_sm]}>
         {!noIcon ? <StarterPack width={40} gradient="sky" /> : null}
         <View>
@@ -96,7 +96,7 @@ export function Link({
 }: {
   starterPack: AppBskyGraphDefs.StarterPackViewBasic
   onPress?: () => void
-  children: React.ReactNode
+  children: BaseLinkProps['children']
 }) {
   const {_} = useLingui()
   const queryClient = useQueryClient()
@@ -123,7 +123,8 @@ export function Link({
           starterPack.creator.did,
         )
         precacheStarterPack(queryClient, starterPack)
-      }}>
+      }}
+      style={[a.flex_col, a.align_start]}>
       {children}
     </BaseLink>
   )