Fix missing recId values for suggested user events (#10291)

Co-authored-by: Eric Bailey <git@esb.lol>
This commit is contained in:
DS Boyce
2026-04-21 13:59:13 -07:00
committed by GitHub
parent bfdaab0a14
commit 07344f70fc
10 changed files with 38 additions and 4 deletions
@@ -105,6 +105,7 @@ export function StepSuggestedAccounts() {
ax.metric('suggestedUser:follow', {
logContext: 'Onboarding',
location: 'FollowAll',
recSource: !useFullExperience ? 'Search' : undefined,
recId: suggestedUsers?.recId,
position: i,
suggestedDid: did,
@@ -155,6 +156,7 @@ export function StepSuggestedAccounts() {
seenProfilesRef.current.add(did)
ax.metric('suggestedUser:seen', {
logContext: 'Onboarding',
recSource: !useFullExperience ? 'Search' : undefined,
recId: suggestedUsers?.recId,
position,
suggestedDid: did,
@@ -162,7 +164,7 @@ export function StepSuggestedAccounts() {
})
}
},
[ax, selectedInterest, suggestedUsers?.recId],
[ax, selectedInterest, suggestedUsers?.recId, useFullExperience],
)
useEffect(() => {
@@ -248,6 +250,7 @@ export function StepSuggestedAccounts() {
position={index}
category={selectedInterest}
onSeen={onProfileSeen}
recSource={!useFullExperience ? 'Search' : undefined}
recId={suggestedUsers.recId}
/>
))}
@@ -358,6 +361,7 @@ function SuggestedProfileCard({
position,
category,
onSeen,
recSource,
recId,
}: {
profile: bsky.profile.AnyProfileView
@@ -365,6 +369,7 @@ function SuggestedProfileCard({
position: number
category: string | null
onSeen: (did: string, position: number) => void
recSource?: 'Search'
recId?: number | string
}) {
const t = useTheme()
@@ -432,6 +437,7 @@ function SuggestedProfileCard({
ax.metric('suggestedUser:follow', {
logContext: 'Onboarding',
location: 'Card',
recSource,
recId,
position,
suggestedDid: profile.did,
+2 -1
View File
@@ -162,7 +162,7 @@ type ExploreScreenItems =
type: 'profile'
key: string
profile: AppBskyActorDefs.ProfileView
recId?: number
recId?: string
}
| {
type: 'profileEmpty'
@@ -406,6 +406,7 @@ export function Explore({
type: 'profile',
key: actor.did,
profile: actor,
recId: suggestedUsers.recId,
})
}
}
@@ -105,7 +105,7 @@ let SuggestedProfileCard = ({
}: {
profile: bsky.profile.AnyProfileView
moderationOpts: ModerationOpts
recId?: number
recId?: string
position: number
}): React.ReactNode => {
const t = useTheme()