Adds hardcoded suggested list (#178)

* Adds hardcoded suggested list

* Update suggested-actors-view to support page sizes smaller than the hardcoded list

---------

Co-authored-by: Paul Frazee <pfrazee@gmail.com>

package.json

@@ -16,7 +16,7 @@
     "e2e": "detox test --configuration ios.sim.debug --take-screenshots all"
   },
   "dependencies": {
-    "@atproto/api": "^0.1.0",
+    "@atproto/api": "^0.1.1",
     "@atproto/lexicon": "^0.0.4",
     "@atproto/xrpc": "^0.0.4",
     "@bam.tech/react-native-image-resizer": "^3.0.4",

src/lib/suggestedFollows.ts

@@ -0,0 +1,65 @@
+const productionSuggestedFollows = [
+  'john',
+  'visakanv ',
+  'saz ',
+  'steph ',
+  'ratzlaff ',
+  'beth',
+  'weisser ',
+  'katherine ',
+  'annagat',
+  'josh',
+  'lurkshark',
+  'amir',
+  'amyxzh',
+  'danielle ',
+  'jack-frazee',
+  'vibes',
+  'cat',
+  'yuriy',
+  'alvinreyes',
+  'skoot',
+  'patricia',
+  'ara4n',
+  'case',
+  'armand',
+  'ivan',
+  'nicholas',
+  'kelsey',
+  'ericlee',
+  'emily',
+  'jake',
+  'jennijuju',
+  'ian5v',
+  'bnewbold',
+  'chris',
+  'mtclai',
+  'willscott',
+  'michael',
+  'kwkroeger',
+  'broox',
+  'iamrosewang',
+  'jack-morrison',
+  'pwang',
+  'martin',
+  'jack',
+  'dan',
+  'why',
+  'divy',
+  'jay',
+  'paul',
+].map(handle => `${handle}.bsky.social`)
+
+const stagingSuggestedFollows = ['arcalinea', 'paul', 'paul2'].map(
+  handle => `${handle}.staging.bsky.dev`,
+)
+
+const devSuggestedFollows = ['alice', 'bob', 'carla'].map(
+  handle => `${handle}.test`,
+)
+
+export {
+  productionSuggestedFollows,
+  stagingSuggestedFollows,
+  devSuggestedFollows,
+}

src/state/models/suggested-actors-view.ts

@@ -1,12 +1,30 @@
 import {makeAutoObservable, runInAction} from 'mobx'
-import {AppBskyActorGetSuggestions as GetSuggestions} from '@atproto/api'
+import {
+  AppBskyActorGetSuggestions as GetSuggestions,
+  AppBskyActorProfile as Profile,
+} from '@atproto/api'
 import {RootStoreModel} from './root-store'
 import {cleanError} from '../../lib/strings'
 import {bundleAsync} from '../../lib/async/bundle'
+import {
+  devSuggestedFollows,
+  productionSuggestedFollows,
+  stagingSuggestedFollows,
+} from '../../lib/suggestedFollows'
 
 const PAGE_SIZE = 30
 
-export type SuggestedActor = GetSuggestions.Actor
+export type SuggestedActor = GetSuggestions.Actor | Profile.View
+
+const getSuggestionList = ({serviceUrl}: {serviceUrl: string}) => {
+  if (serviceUrl.includes('localhost')) {
+    return devSuggestedFollows
+  } else if (serviceUrl.includes('staging')) {
+    return stagingSuggestedFollows
+  } else {
+    return productionSuggestedFollows
+  }
+}
 
 export class SuggestedActorsViewModel {
   // state
@@ -18,6 +36,8 @@ export class SuggestedActorsViewModel {
   hasMore = true
   loadMoreCursor?: string
 
+  private hardCodedSuggestions: SuggestedActor[] | undefined
+
   // data
   suggestions: SuggestedActor[] = []
 
@@ -57,6 +77,9 @@ export class SuggestedActorsViewModel {
     if (!replace && !this.hasMore) {
       return
     }
+    if (replace) {
+      this.hardCodedSuggestions = undefined
+    }
     this._xLoading(replace)
     try {
       let items: SuggestedActor[] = this.suggestions
@@ -66,13 +89,27 @@ export class SuggestedActorsViewModel {
       }
       let res
       do {
-        res = await this.rootStore.api.app.bsky.actor.getSuggestions({
+        await this.fetchHardcodedSuggestions()
-          limit: this.pageSize,
+        if (this.hardCodedSuggestions && this.hardCodedSuggestions.length > 0) {
-          cursor: this.loadMoreCursor,
+          // pull from the hard-coded suggestions
-        })
+          const newItems = this.hardCodedSuggestions.splice(0, this.pageSize)
-        this.loadMoreCursor = res.data.cursor
+          items = items.concat(newItems)
-        this.hasMore = !!this.loadMoreCursor
+          this.hasMore = true
-        items = items.concat(res.data.actors)
+          this.loadMoreCursor = undefined
+        } else {
+          // pull from the PDS' algo
+          res = await this.rootStore.api.app.bsky.actor.getSuggestions({
+            limit: this.pageSize,
+            cursor: this.loadMoreCursor,
+          })
+          this.loadMoreCursor = res.data.cursor
+          this.hasMore = !!this.loadMoreCursor
+          items = items.concat(
+            res.data.actors.filter(
+              actor => !items.find(i => i.did === actor.did),
+            ),
+          )
+        }
       } while (items.length < this.pageSize && this.hasMore)
       runInAction(() => {
         this.suggestions = items
@@ -83,6 +120,32 @@ export class SuggestedActorsViewModel {
     }
   })
 
+  private async fetchHardcodedSuggestions() {
+    if (!this.hardCodedSuggestions) {
+      try {
+        const suggestionsList = getSuggestionList({
+          serviceUrl: this.rootStore.session.currentSession?.service || '',
+        })
+        const res = await this.rootStore.api.app.bsky.actor.getProfiles({
+          actors: suggestionsList,
+        })
+        runInAction(() => {
+          this.hardCodedSuggestions = res.data.profiles.filter(
+            profile => !profile.myState?.follow,
+          )
+        })
+      } catch (e) {
+        this.rootStore.log.error(
+          'Failed to getProfiles() for suggested follows',
+          {e},
+        )
+        runInAction(() => {
+          this.hardCodedSuggestions = []
+        })
+      }
+    }
+  }
+
   // state transitions
   // =
 

yarn.lock

@@ -19,10 +19,10 @@
     jsonpointer "^5.0.0"
     leven "^3.1.0"
 
-"@atproto/api@^0.1.0":
+"@atproto/api@^0.1.1":
-  version "0.1.0"
+  version "0.1.1"
-  resolved "https://registry.yarnpkg.com/@atproto/api/-/api-0.1.0.tgz#0677cdde0a8b943b904dbc3f7f7357b329eca48a"
+  resolved "https://registry.yarnpkg.com/@atproto/api/-/api-0.1.1.tgz#0215dd80b98b8698f9e08932d4cdaf52676cb56c"
-  integrity sha512-+vKAEEgh3GgLfK/QZGAoQKesmhYcCsuiiEzr1miCQAuf7zfTsbX27zHERIuEVT+TqTH98MNbd3uyzF/NAbYMwQ==
+  integrity sha512-OMKLXuWxsdaHmmZ8XzwZ1uzWpq1sr9cuzZJLAbWJz0HRDQ3a0tg1uI80XvDYHFep0qgVoT2OKJNtB23Wp7nKoQ==
   dependencies:
     "@atproto/xrpc" "*"
     typed-emitter "^2.1.0"