From 0004e27427adb224427b50375625830abc346bd0 Mon Sep 17 00:00:00 2001 From: Samuel Newman Date: Fri, 4 Apr 2025 18:24:26 +0300 Subject: [PATCH] [Explore] Add index to view metric (#8124) * add index to view metric * supply index * always return a number --- src/logger/metrics.ts | 1 + src/screens/Search/Explore.tsx | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/logger/metrics.ts b/src/logger/metrics.ts index 6467583692..0cbacaf1a4 100644 --- a/src/logger/metrics.ts +++ b/src/logger/metrics.ts @@ -330,6 +330,7 @@ export type MetricEvents = { | 'suggestedFeeds' | 'suggestedStarterPacks' | `feed:${FeedDescriptor}` + index: number } 'explore:module:searchButtonPress': { module: 'suggestedAccounts' | 'suggestedFeeds' diff --git a/src/screens/Search/Explore.tsx b/src/screens/Search/Explore.tsx index d1ea4be97d..00eb6c4330 100644 --- a/src/screens/Search/Explore.tsx +++ b/src/screens/Search/Explore.tsx @@ -888,7 +888,7 @@ export function Explore({ viewableItems: ViewToken[] changed: ViewToken[] }) => { - for (const {item} of viewableItems.filter(vi => vi.isViewable)) { + for (const {item, index} of viewableItems.filter(vi => vi.isViewable)) { let module: MetricEvents['explore:module:seen']['module'] if (item.type === 'trendingTopics' || item.type === 'trendingVideos') { module = item.type @@ -905,7 +905,7 @@ export function Explore({ } if (!alreadyReportedRef.current.has(module)) { alreadyReportedRef.current.set(module, module) - logger.metric('explore:module:seen', {module}) + logger.metric('explore:module:seen', {module, index: index ?? -1}) } } },